feat(NET-449): add sync feature to request a host pull from server #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aceix
requested review from
theguy951357,
gabrielseibel1,
afeiszli,
abhishek9686,
mattkasun and
uGiFarukh
abhishek9686
approved these changes
Aug 2, 2023
mattkasun
approved these changes
Aug 2, 2023
theguy951357
approved these changes
Aug 3, 2023
mattkasun
pushed a commit
that referenced
this pull request
Aug 8, 2023
abhishek9686
added a commit
that referenced
this pull request
Aug 14, 2023
* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <[email protected]> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> Co-authored-by: Abhishek K <[email protected]> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos --------- Co-authored-by: Aceix <[email protected]> Co-authored-by: Abhishek K <[email protected]> Co-authored-by: Farukh Khan <[email protected]> Co-authored-by: Gabriel de Souza Seibel <[email protected]> Co-authored-by: bornav <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]>
mattkasun
pushed a commit
that referenced
this pull request
Aug 14, 2023
mattkasun
added a commit
that referenced
this pull request
Aug 14, 2023
* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <[email protected]> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> Co-authored-by: Abhishek K <[email protected]> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos --------- Co-authored-by: Aceix <[email protected]> Co-authored-by: Abhishek K <[email protected]> Co-authored-by: Farukh Khan <[email protected]> Co-authored-by: Gabriel de Souza Seibel <[email protected]> Co-authored-by: bornav <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]>
abhishek9686
added a commit
that referenced
this pull request
Aug 16, 2023
* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <[email protected]> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> Co-authored-by: Abhishek K <[email protected]> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos * fix convertsion of persistent keepalive * remove weird paste * another paste error --------- Co-authored-by: Aceix <[email protected]> Co-authored-by: Abhishek K <[email protected]> Co-authored-by: Farukh Khan <[email protected]> Co-authored-by: Gabriel de Souza Seibel <[email protected]> Co-authored-by: bornav <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]>
abhishek9686
added a commit
that referenced
this pull request
Aug 16, 2023
* create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <[email protected]> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> Co-authored-by: Abhishek K <[email protected]> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos * fix convertsion of persistent keepalive * remove weird paste * another paste error * fix command typo --------- Co-authored-by: Matthew R Kasun <[email protected]> Co-authored-by: Aceix <[email protected]> Co-authored-by: Farukh Khan <[email protected]> Co-authored-by: Gabriel de Souza Seibel <[email protected]> Co-authored-by: bornav <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]>
abhishek9686
added a commit
that referenced
this pull request
Aug 25, 2023
* use NewHosts to init hostfile * Revert "Bump github.com/txn2/txeh from 1.4.0 to 1.5.3 (#2464)" (#2475) This reverts commit aafaa91. * NET-433: Only Set Routes for NAT enabled egress GW (#2469) * remove related fields and code * remover metrics collection from server code * fw update struct * add ext client flag to metrics data * simply nat types * rm proxy update from cli * remove ingress routes from firewall update * check if egress ranges are present * rm unused func * ignore network parameter passed to delete ingress endpoint (#2471) * fix(NET-388): fix to update node dns toggle (#2472) * use local port for metrics pinger (#2479) * v0.20.5 release notes (#2482) * v0.20.5 release notes * add a known issue * update develop to v0.20.6 (#2485) * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <[email protected]> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> Co-authored-by: Abhishek K <[email protected]> * Bump github.com/go-playground/validator/v10 from 10.14.1 to 10.15.0 (#2503) Bumps [github.com/go-playground/validator/v10](https://github.com/go-playground/validator) from 10.14.1 to 10.15.0. - [Release notes](https://github.com/go-playground/validator/releases) - [Commits](go-playground/validator@v10.14.1...v10.15.0) --- updated-dependencies: - dependency-name: github.com/go-playground/validator/v10 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump golang.org/x/oauth2 from 0.10.0 to 0.11.0 (#2502) Bumps [golang.org/x/oauth2](https://github.com/golang/oauth2) from 0.10.0 to 0.11.0. - [Commits](golang/oauth2@v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: golang.org/x/oauth2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump alpine from 3.18.2 to 3.18.3 (#2500) Bumps alpine from 3.18.2 to 3.18.3. --- updated-dependencies: - dependency-name: alpine dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Net 509 515 (#2496) * NET-509 * External client config files with IPv6 endpoints now have the [] separating the address and port. * NET-515 * Increased network name max length to 32 * NET-509-515 * Updated unit test for network name max length check. * Updated extclient endpoint ip string manipulation to use sprintf * Added proper error message for network name length more than max allowed. * NET-515 small typo fix for error strings should not be capitalized * [NET-494 / ACC-322] New free tier limits (#2495) * Rename var * Rename consts and use iota * Use switch instead of repeated else if * Rename limits related vars * Introduce new free tier limits * Measure new limits and report on license validation * Separate usage and limits, have new ones * Don't check for hosts and clients limits, but for machines instead * Error on egress creation @ free tier w/ internet gateways * Remove clients and hosts limit from code * Rename var * Rename consts and use iota * Use switch instead of repeated else if * Rename limits related vars * Introduce new free tier limits * Measure new limits and report on license validation * Separate usage and limits, have new ones * Don't check for hosts and clients limits, but for machines instead * Error on egress creation @ free tier w/ internet gateways * Remove clients and hosts limit from code * NET-507 (#2506) * NET-507 * Fixed server restart changing the node expiration date to the defaults. * Removed expired nodes removal from zombie cleanup routine. * Added a new expired nodes deletion routine which removes expired nodes every hour. * NET-507 suggested changes * Possible fix for zombie nodes upon node deletion from the UI. * Suggested changes implemented for expired nodes deletion go routine. * NET-507 typo fix * typo fix for DeleteNode purge parameter * NET-517 (#2510) * Fixed emqx docker compose file syntax and added volumes for persistence. * Added helper comments for docker-compose.yml and netmaker.env files to enable emqx broker support. * migration (#2509) * create gateways during migration * set version for testing * restruct migration * debug logging * enforce unique names for ext client names (#2476) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * prune(NET-483): remove defunct host.internetgateway field (#2487) * don't reference host on err (#2493) * deprecrate netclient install scripts (#2490) * Net 500: validate network parameter passed to node endpoints (#2480) * enforce unique names for ext client names * only check for unique id on creation * check for unique id if changed * validate network parameter passed to node endpoints --------- Co-authored-by: Abhishek K <[email protected]> * NET-513 (#2492) nm-certs.sh now requests certificate for EE and CE edition domains accordingly. * [NET-404] Run in limited mode when ee checks fail (#2474) * Add limited http handlers functionality to rest handler * Export ee.errValidation (ee.ErrValidation) * Export a fatal error handled by the hook manager * Export a new status variable for unlicensed server * Mark server as unlicensed when ee checks fail * Handle license validation failures with a (re)boot in a limited state * Revert "Export a fatal error handled by the hook manager" This reverts commit 069c219. * Revert "Export ee.errValidation (ee.ErrValidation)" This reverts commit 59dbab8. * Revert "Add limited http handlers functionality to rest handler" This reverts commit e2f1f28. * Revert "Handle license validation failures with a (re)boot in a limited state" This reverts commit 58cfbba. * Revert "Mark server as unlicensed when ee checks fail" This reverts commit 77c6dbd. * Handle license validation failures with a middleware * Forbid responses if unlicensed ee and not in status api * Remove unused func * feat(NET-449): add sync feature to request a host pull from server (#2491) * fix(NET-486): change client name length validation (#2498) set limit to 5<=x<=32 * [NET-477] Pick AMB URL dynamically (#2489) * Introduce config for environment * Introduce func to get environment * Choose accounts api host from environment * Test the ee package on workflows * Use build tag ee for license_test.go * [Feature]: nm-quick script tackling arm TODO support (#2488) * domain flag for auto installs * use static servers with custom domain (#2421) * send delete peer update always * fix add/remove host api calls * keep mq updates in a single go func * move branch test logic to devops (#2443) * handle IOT OS * save server name to env (#2460) * ensure branch test servers available after test runs (#2467) * save server name to env * free server always; add PR to discord messages * use correct method to delete droplets (#2468) * quick fix for the launcher * removed exit when triggering not supported exit and removed the TODO comments related to this issue --------- Co-authored-by: Matthew R Kasun <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> Co-authored-by: Abhishek K <[email protected]> * rebase conflict * include pass and os in mirgration data * node network ranges * remove debugging logs * add gateways * use sent node * upgrade shell script * associate node to host during migration * add node to host.Nodes and publish peer update * save host outside loop * fix script name * simplify upgrade script * don't migrate relays * simplify upgrade script even more * guard against blank address or address6 * typos --------- Co-authored-by: Aceix <[email protected]> Co-authored-by: Abhishek K <[email protected]> Co-authored-by: Farukh Khan <[email protected]> Co-authored-by: Gabriel de Souza Seibel <[email protected]> Co-authored-by: bornav <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> * dns tests * go mod tidy * set dns dir when testing * troubleshoot test failure * test fail troubleshooting * use txeh.RenderHostFile to compare --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Abhishek K <[email protected]> Co-authored-by: Aceix <[email protected]> Co-authored-by: Christopher Blaha <[email protected]> Co-authored-by: Farukh Khan <[email protected]> Co-authored-by: Gabriel de Souza Seibel <[email protected]> Co-authored-by: bornav <[email protected]> Co-authored-by: Alex Feiszli <[email protected]> Co-authored-by: Abhishek Kondur <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Check story
Provide Issue ticket number if applicable/not in title
Provide testing steps
Checklist before requesting a review