Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NET-1315:exclude InetClient for network change detection #824

Merged
merged 1 commit into from
Jun 14, 2024

Conversation

yabinma
Copy link
Collaborator

@yabinma yabinma commented Jun 13, 2024

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

@abhishek9686 abhishek9686 merged commit d75e548 into NET-1315 Jun 14, 2024
4 checks passed
@yabinma yabinma deleted the NET-1315-max branch June 14, 2024 15:33
abhishek9686 added a commit that referenced this pull request Jun 24, 2024
… broker conn lost handler (#810)

* add public ip detection thread

* restart on public ip change

* set proto to zero to get relevant ip

* hard restart on IP changes

* add only ip one voter to debug

* ignore public ip from stun

* update log level from error to warn

* clean up logs, inital ip fetch logic

* add debug log

* fix ipv6 stun dns resolve issue (#812)

* use only stun to discover public ip

* fallback to ip service if stun fails,remove netmaker stun servers

* change log level from error to warn

* exclude InetClient for network change detection (#824)

* fix ipv6 only wgPublicListenPort issue

---------

Co-authored-by: Max Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants