replace peers on peer/host update #491
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattkasun
requested review from
TobiaszCudnik,
Aceix,
theguy951357,
gabrielseibel1,
afeiszli and
abhishek9686
theguy951357
approved these changes
Jul 7, 2023
abhishek9686
requested changes
Jul 10, 2023
abhishek9686
requested changes
Jul 10, 2023
There was a problem hiding this comment.
This PR will solve the issue with peer deletions: gravitl/netmaker#2445
we shouldn't be replacing peers on every peer update, it will interfere with active connections, it's a costly operation it becomes more evident at scale
for your reference: https://github.com/WireGuard/wireguard-go/blob/469159ecf7d108dc1d44f8789dedbb463b7bd3a6/device/uapi.go#L243
There was a problem hiding this comment.
this is an interim fix until peer update refactor is complete
There was a problem hiding this comment.
this PR has the fixes needed: gravitl/netmaker#2445
There was a problem hiding this comment.
and peer update refactor won't go in until a couple of releases
|
obe due to gravitl/netmaker#2445 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.