New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding free port check #483

Merged

afeiszli merged 3 commits into develop from fix-issues

Jun 29, 2023

Contributor

afeiszli commented Jun 29, 2023

Describe your changes

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

Checklist before requesting a review

My changes affect only 10 files or less.
I have performed a self-review of my code and tested it.
If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
If it is a bugfix, my code is <= 200 lines.
My functions are <= 80 lines.
I have had my code reviewed by a peer.
My unit tests pass locally.
Netclient & Netmaker are awesome.

afeiszli and others added 3 commits

June 29, 2023 11:58


adding free port check

ab34af3


do not overwrite public port values from server

98d56af


check proxy ports always

b0e65a0

afeiszli marked this pull request as ready for review

June 29, 2023 18:39

theguy951357 approved these changes

View reviewed changes

afeiszli merged commit 7a285ba into develop

8 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment