Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scaling fixes #479

Merged
merged 4 commits into from
Jun 28, 2023
Merged

Scaling fixes #479

merged 4 commits into from
Jun 28, 2023

Conversation

abhishek9686
Copy link
Member

@abhishek9686 abhishek9686 commented Jun 27, 2023

Describe your changes

  • Remove Endpoint detection from host model
  • Reset turn connection check timer on peer update
  • Remove auto switch on of proxy

Provide Issue ticket number if applicable/not in title

Provide link to Netmaker PR if required

Provide testing steps

  • No testing is required

Checklist before requesting a review

  • My changes affect only 10 files or less.
  • I have performed a self-review of my code and tested it.
  • If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
  • If it is a bugfix, my code is <= 200 lines.
  • My functions are <= 80 lines.
  • I have had my code reviewed by a peer.
  • My unit tests pass locally.
  • Netclient & Netmaker are awesome.

Copy link
Contributor

@Aceix Aceix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just trying to understand: why get this from peer updates and not from the server?

@abhishek9686
Copy link
Member Author

abhishek9686 commented Jun 28, 2023

just trying to understand: why get this from peer updates and not from the server?

endpoint detection is run on peer updates, say you change the config on the server, there is no way to propagate it unless you run pull on each of your clients if it's in the server config, and since this is global config doesn't make sense to keep it in the host model

@abhishek9686 abhishek9686 requested a review from Aceix June 28, 2023 01:44
@abhishek9686 abhishek9686 changed the title use endpoint detection config from peer update Scaling fixes Jun 28, 2023
@afeiszli afeiszli merged commit 3098e88 into develop Jun 28, 2023
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants