Skip to content

Commit

Permalink
docs(gv-table): add notes about select integration
Browse files Browse the repository at this point in the history
fix: #329
  • Loading branch information
gcusnieux committed Nov 16, 2021
1 parent 1374218 commit 7de4795
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
4 changes: 3 additions & 1 deletion src/atoms/gv-select.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,9 @@ import { InputElement } from '../mixins/input-element';
import { withResizeObserver } from '../mixins/with-resize-observer';

/**
* A select component.
* A select component, is more like a list box...
* ⚠️ Please use `<gv-select-native>` component if you don't need strong customization.
* ⚠️ DO NO USE IT inside a `<gv-table>` component to avoid any scroll or overlapping issue.
*
* ## Details
* * has @theme facet
Expand Down
4 changes: 2 additions & 2 deletions stories/molecules/gv-table.stories.js
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export const components = makeStory(conf, {
data: [
{ field: 'name', label: 'Name' },
{ field: 'value', label: 'Component', type: 'gv-input', attributes: { clipboard: true } },
{ label: 'List', type: 'gv-select', attributes: { options: ['Admin', 'Owner'] } },
{ label: 'List', type: 'gv-select-native', attributes: { options: ['Admin', 'Owner'] } },
{ label: 'Button', type: 'gv-button', attributes: { innerHTML: 'Click me !' } },
{
label: 'Confirm',
Expand Down Expand Up @@ -194,7 +194,7 @@ export const dynamicRows = makeStory(conf, {
{
field: 'name',
label: 'Name',
type: (item) => (item._new ? 'gv-input' : item._select ? 'gv-select' : 'label'),
type: (item) => (item._new ? 'gv-input' : item._select ? 'gv-select-native' : 'label'),
attributes: {
innerHTML: (item) => (item._new ? '' : item.name),
required: true,
Expand Down

0 comments on commit 7de4795

Please sign in to comment.