Skip to content

Commit

Permalink
fix: Revert do not use 4.1.4 with version lower or equal to 4.3.x => …
Browse files Browse the repository at this point in the history
…4.1.x
  • Loading branch information
wbabyte committed Jul 31, 2024
1 parent a8335d5 commit 67d2208
Show file tree
Hide file tree
Showing 4 changed files with 12 additions and 29 deletions.
30 changes: 6 additions & 24 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -30,17 +30,16 @@
<parent>
<groupId>io.gravitee</groupId>
<artifactId>gravitee-parent</artifactId>
<version>22.1.0</version>
<version>22.0.2</version>
</parent>

<properties>
<gravitee-bom.version>7.0.23</gravitee-bom.version>
<gravitee-common.version>4.4.0</gravitee-common.version>
<gravitee-gateway-api.version>3.5.0</gravitee-gateway-api.version>
<gravitee-node.version>5.18.3</gravitee-node.version>
<gravitee-apim.version>4.4.0</gravitee-apim.version>

<gravitee-bom.version>6.0.3</gravitee-bom.version>
<gravitee-gateway-api.version>3.0.0</gravitee-gateway-api.version>
<gravitee-policy-api.version>1.11.0</gravitee-policy-api.version>
<gravitee-node.version>3.1.0</gravitee-node.version>
<gravitee-common.version>3.3.3</gravitee-common.version>
<gravitee-apim.version>4.1.0-SNAPSHOT</gravitee-apim.version>

<nimbus-jose-jwt.version>9.15.2</nimbus-jose-jwt.version>
<sshj.version>0.35.0</sshj.version>
Expand Down Expand Up @@ -78,13 +77,6 @@
<artifactId>gravitee-common</artifactId>
<version>${gravitee-common.version}</version>
</dependency>
<dependency>
<groupId>io.gravitee.node</groupId>
<artifactId>gravitee-node</artifactId>
<version>${gravitee-node.version}</version>
<scope>import</scope>
<type>pom</type>
</dependency>
</dependencies>
</dependencyManagement>

Expand All @@ -105,16 +97,6 @@
<artifactId>gravitee-common</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.gravitee.node</groupId>
<artifactId>gravitee-node-api</artifactId>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.gravitee.node</groupId>
<artifactId>gravitee-node-vertx</artifactId>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>com.nimbusds</groupId>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@
package io.gravitee.policy.jwt.jwk.source;

import com.nimbusds.jose.util.Resource;
import io.gravitee.common.util.VertxProxyOptionsUtils;
import io.gravitee.node.api.configuration.Configuration;
import io.gravitee.node.vertx.proxy.VertxProxyOptionsUtils;
import io.reactivex.rxjava3.core.Single;
import io.vertx.core.http.HttpClientOptions;
import io.vertx.core.http.HttpHeaders;
Expand Down Expand Up @@ -84,7 +84,7 @@ private HttpClient buildHttpClient(URL url) {

if (useSystemProxy) {
try {
options.setProxyOptions(VertxProxyOptionsUtils.buildProxyOptions(configuration));
VertxProxyOptionsUtils.setSystemProxy(options, configuration);
} catch (Exception e) {
log.warn(
"JWTPlugin requires a system proxy to be defined to retrieve resource [{}] but some configurations are missing or not well defined: {}",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,10 @@
*/
package io.gravitee.policy.v3.jwt.jwks.retriever;

import static io.gravitee.common.util.VertxProxyOptionsUtils.setSystemProxy;

import com.nimbusds.jose.util.Resource;
import io.gravitee.node.api.configuration.Configuration;
import io.gravitee.node.vertx.proxy.VertxProxyOptionsUtils;
import io.vertx.core.Future;
import io.vertx.core.Promise;
import io.vertx.core.Vertx;
Expand Down Expand Up @@ -57,7 +58,7 @@ public CompletableFuture<Resource> retrieve(URL url) {

if (useSystemProxy) {
try {
options.setProxyOptions(VertxProxyOptionsUtils.buildProxyOptions(configuration));
setSystemProxy(options, configuration);
} catch (Exception e) {
LOGGER.warn(
"JWTPlugin requires a system proxy to be defined to retrieve resource [{}] but some configurations are missing or not well defined: {}",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@
import java.util.Date;
import java.util.stream.Stream;
import net.schmizz.sshj.common.Buffer;
import org.apache.commons.lang3.RandomStringUtils;
import org.junit.jupiter.params.provider.Arguments;
import wiremock.org.apache.commons.lang3.RandomStringUtils;

/**
* @author Jeoffrey HAEYAERT (jeoffrey.haeyaert at graviteesource.com)
Expand Down

0 comments on commit 67d2208

Please sign in to comment.