fix(metrics): hold strong reference to probes results in micrometer g…

…auge
gravitee-io · Oct 4, 2024 · e17fa16 · e17fa16
1 parent 90eaf81
commit e17fa16
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...itee-node-monitoring/src/main/java/io/gravitee/node/monitoring/DefaultProbeEvaluator.java b/...itee-node-monitoring/src/main/java/io/gravitee/node/monitoring/DefaultProbeEvaluator.java
@@ -72,4 +72,8 @@ public CompletableFuture<Map<Probe, Result>> evaluate(final Set<String> probeIds
                 }
             });
     }
+
+    public Map<Probe, Result> getCachedResults() {
+        return lastProbeResults;
+    }
 }
diff --git a/.../io/gravitee/node/monitoring/healthcheck/micrometer/NodeHealthCheckMicrometerHandler.java b/.../io/gravitee/node/monitoring/healthcheck/micrometer/NodeHealthCheckMicrometerHandler.java
@@ -41,7 +41,7 @@ public void bindTo(@NonNull MeterRegistry registry) {
         try {
             for (Map.Entry<Probe, Result> entry : probeRegistry.evaluate().get().entrySet()) {
                 Gauge
-                    .builder("node", entry, e -> e.getValue().isHealthy() ? 1d : 0d)
+                    .builder("node", probeRegistry, e -> e.getCachedResults().get(entry.getKey()).isHealthy() ? 1d : 0d)
                     .tag("probe", entry.getKey().id())
                     .description("The health-check probes of the node")
                     .baseUnit("health")
-Original file line number
+Diff line change
@@ Expand Up @@
                     }
                 });
         }
+        public Map<Probe, Result> getCachedResults() {
+            return lastProbeResults;
+        }
     }