Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

am(cors): domain level CORS doc #1010

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ashraf706
Copy link
Contributor

@ashraf706 ashraf706 commented Mar 15, 2023

This documentation is for 3.21.x domain level CORS configuration

🚀 CI was able to deploy the build of this PR, so you can now try it directly here

@ashraf706 ashraf706 requested review from a team as code owners March 15, 2023 14:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

= CORS Configuration
:page-sidebar: am_3_x_sidebar
:page-permalink: am/current/am_userguide_cors_configuration.html
:page-folde![](../../../../../../../../../Desktop/graviteeio-am-userguide-cors-default.png)r: am/user-guide

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:page-folde![](../../../../../../../../../Desktop/graviteeio-am-userguide-cors-default.png)r: am/user-guide
:page-folder: am/user-guide

=== Access-Control-Allow-Origin

Allow to specify one or multiples origin(s) that may access the resource.
If you want to allow all origins, you can put `*` but it's not safe for production.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you want to allow all origins, you can put `*` but it's not safe for production.
If you want to allow all origins, you can put `*` but this is not safe for production.

Here you specify the headers allowed to be used by your requests.
Typically, on your request headers you will have a header `Access-Control-Request-Headers` which request CORS to be configured to allow its values.

Let's see a simple use case:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Let's see a simple use case:
==== Simple use case


Here is the screenshot of these variables from the `gravitee.yml` file

image::{% link images/am/current/graviteeio-am-userguide-cors-settings-yml.png %}[Gateway CORS defailt settings,500,400]

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use a screenshot (which I find difficult to read) when you could just copy and paste an example directly from the gravitee.yml file?

Base automatically changed from am-3.21 to master May 25, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants