Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(console) resume endpoint for failed customer status #10125

Open
wants to merge 1 commit into
base: 4.4.x
Choose a base branch
from

Conversation

skorda42
Copy link
Contributor

@skorda42 skorda42 commented Dec 13, 2024

Issue

https://gravitee.atlassian.net/browse/APIM-7811

Description

Adding possibility to resume failed subscription when backend failed

Additional context


📚  View the storybook of this branch here

@skorda42 skorda42 force-pushed the APIM-7811-publisher-can-resume-failed-subscription branch 11 times, most recently from c092dfc to b0d6f43 Compare December 17, 2024 10:38
@skorda42 skorda42 marked this pull request as ready for review December 17, 2024 10:38
@skorda42 skorda42 requested a review from a team as a code owner December 17, 2024 10:38
@skorda42 skorda42 force-pushed the APIM-7811-publisher-can-resume-failed-subscription branch from b0d6f43 to c7b442b Compare December 17, 2024 11:04
subscription
);
@Override
public SubscriptionEntity resumeFailure(final ExecutionContext executionContext, String subscriptionId) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure to understand why you need this new resumeFailure method (and Resource)
imho it is already the purpose of resumeConsumer() method, even if it might need some adaptation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed but after discussion with Ouahid we decided to move it to the separate endpoint

@skorda42 skorda42 force-pushed the APIM-7811-publisher-can-resume-failed-subscription branch 3 times, most recently from a6010e6 to 0f7cc6e Compare December 18, 2024 08:32
@skorda42 skorda42 force-pushed the APIM-7811-publisher-can-resume-failed-subscription branch from 0f7cc6e to 1d0a8cb Compare December 18, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants