-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(console) resume endpoint for failed customer status #10125
base: 4.4.x
Are you sure you want to change the base?
Conversation
c092dfc
to
b0d6f43
Compare
b0d6f43
to
c7b442b
Compare
...main/java/io/gravitee/rest/api/management/v2/rest/resource/api/ApiSubscriptionsResource.java
Outdated
Show resolved
Hide resolved
...main/java/io/gravitee/rest/api/management/v2/rest/resource/api/ApiSubscriptionsResource.java
Outdated
Show resolved
Hide resolved
...main/java/io/gravitee/rest/api/management/v2/rest/resource/api/ApiSubscriptionsResource.java
Outdated
Show resolved
Hide resolved
...ee-apim-rest-api-service/src/main/java/io/gravitee/rest/api/service/SubscriptionService.java
Outdated
Show resolved
Hide resolved
...est-api-service/src/main/java/io/gravitee/rest/api/service/impl/SubscriptionServiceImpl.java
Outdated
Show resolved
Hide resolved
...est-api-service/src/main/java/io/gravitee/rest/api/service/impl/SubscriptionServiceImpl.java
Show resolved
Hide resolved
subscription | ||
); | ||
@Override | ||
public SubscriptionEntity resumeFailure(final ExecutionContext executionContext, String subscriptionId) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure to understand why you need this new resumeFailure method (and Resource)
imho it is already the purpose of resumeConsumer()
method, even if it might need some adaptation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed but after discussion with Ouahid we decided to move it to the separate endpoint
a6010e6
to
0f7cc6e
Compare
0f7cc6e
to
1d0a8cb
Compare
Issue
https://gravitee.atlassian.net/browse/APIM-7811
Description
Adding possibility to resume failed subscription when backend failed
Additional context
📚 View the storybook of this branch here