APIM 7767 fix: empty endpoint group check #10086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Okhelifi
reviewed
Dec 13, 2024
...apim-console-webui/src/management/api/proxy/health-check/api-proxy-health-check.component.ts
Outdated
Show resolved
Hide resolved
...apim-console-webui/src/management/api/proxy/health-check/api-proxy-health-check.component.ts
Show resolved
Hide resolved
mukul-tyagi08
force-pushed
the
APIM-7767-fix-empty-endpoint-group-check
branch
from
802ebc1 to
9650834
Compare
Okhelifi
reviewed
Dec 16, 2024
...console-webui/src/management/api/proxy/health-check/api-proxy-health-check.component.spec.ts
Outdated
Show resolved
Hide resolved
mukul-tyagi08
force-pushed
the
APIM-7767-fix-empty-endpoint-group-check
branch
from
9650834 to
387ccb0
Compare
mukul-tyagi08
force-pushed
the
APIM-7767-fix-empty-endpoint-group-check
branch
from
387ccb0 to
9dac19e
Compare
wbabyte
approved these changes
Dec 17, 2024
This was referenced Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
https://gravitee.atlassian.net/browse/APIM-7767
Description
Added empty endpoint group check and a try-catch while updating endpoint groups.
Additional context
Before:
While saving healthCheck:
After:
📚 View the storybook of this branch here