This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 308
Collect logos for promoting companies #4656
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadwhitacre
force-pushed
the
promo-logo
branch
from
September 28, 2017 22:25
7659855
to
3a86497
Compare
chadwhitacre
force-pushed
the
promo-logo
branch
from
September 28, 2017 23:08
3a86497
to
33f8b6f
Compare
39 tasks
chadwhitacre
force-pushed
the
promo-logo
branch
4 times, most recently
from
October 3, 2017 15:58
ef8db7f
to
d2077b1
Compare
Right! So ... I have this working manually, now working on adding it to the ttw and py tests. |
chadwhitacre
force-pushed
the
promo-logo
branch
from
October 3, 2017 21:52
218eb57
to
45c517f
Compare
Rebased, was 218eb57. |
Rebased, was 45c517f. |
chadwhitacre
force-pushed
the
promo-logo
branch
2 times, most recently
from
October 4, 2017 19:50
cda6668
to
08e2fc5
Compare
The line ∆ is huge because of fixture changes. :-/ |
chadwhitacre
force-pushed
the
promo-logo
branch
2 times, most recently
from
October 4, 2017 20:17
14ef741
to
223248d
Compare
Yay green! @dmk246 started looking at this today but we ran out of time. If anyone else has time before tomorrow, go for it! :D cc: @JessaWitzel @mattbk @rohitpaulk @kaguillera @dowski et al. |
chadwhitacre
force-pushed
the
promo-logo
branch
from
October 5, 2017 12:18
223248d
to
9268d35
Compare
PNG uploading is working for me. |
Cropping works. |
Looks good to me. |
Planning to merge per @mattbk's approval. |
chadwhitacre
force-pushed
the
video-etc
branch
from
October 6, 2017 21:04
2da2a71
to
b3e27ed
Compare
Rebased, was f86b304. |
chadwhitacre
force-pushed
the
promo-logo
branch
2 times, most recently
from
October 6, 2017 21:32
242202d
to
0d40c82
Compare
Only a basic ttw test due to Selenium limitations.
chadwhitacre
force-pushed
the
promo-logo
branch
from
October 6, 2017 21:34
0d40c82
to
f715e3b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of gratipay/inside.gratipay.com#1160.
.insert
—maybe share code w/Team.save_image
?homepage.py
(make sure it's optional)/browse/payments/%uuid/logo
?change base back to master