-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed introspection field "specifiedBy" to "specifiedByURL" #848
Conversation
@Code-Hex Thanks for opening it 👍 Context: #649 (comment)
But Also, I think cc: @leebyron |
Thanks for opening this - I thought we had handled this, but perhaps we missed something. While you're at it, can you make sure prose is updated accordingly? Example:
to
|
@leebyron I've done it. Could you review please. |
I think you made a typo with GraphQLJSON https://github.com/taion/graphql-type-json/blob/master/src/index.js#L55-L56 and other scalars distributed via NPM now lost PS. The opened issue for this typo: graphql/graphql-js#3156 |
specifiedBy
should bespecifiedByURL
to be consistent withdeprecatedReason
representing@deprecated(reason: "")
directive. (I agreed this direction)