Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add references to known GraphQL scalars #1277

Merged
merged 6 commits into from
Aug 16, 2024

Conversation

sgoll
Copy link
Contributor

@sgoll sgoll commented Aug 15, 2024

Similar to #1275

Description

This PR adds references (links) to GraphQL scalars that are well-known and documented at https://graphql-scalars.dev.

Some of these links were missing because the associated types had not been defined at the time the corresponding feature was added.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::documentation Related to project documentation k::integration Related to integration with third-party libraries or systems lib::bson Related to `bson` crate integration labels Aug 15, 2024
@tyranron tyranron added this to the 0.17.0 milestone Aug 15, 2024
# Conflicts:
#	book/src/types/scalars.md
#	juniper/src/integrations/bson.rs
#	juniper/src/integrations/chrono.rs
#	juniper/src/integrations/chrono_tz.rs
#	juniper/src/integrations/time.rs
#	juniper/src/integrations/url.rs
#	juniper/src/integrations/uuid.rs
@tyranron tyranron added lib::chrono Related to `chrono` crate integration lib::time Related to `time` crate integration labels Aug 15, 2024
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgoll thanks! This one definitely showed me some stuff I hadn't noticed in #1275.

@sgoll
Copy link
Contributor Author

sgoll commented Aug 15, 2024

@sgoll thanks! This one definitely showed me some stuff I hadn't noticed in #1275.

Oh, I hadn't realized you were also working on this 😅 Great work! 👍

@tyranron tyranron added the semver::breaking Breaking change in terms of SemVer label Aug 16, 2024
@tyranron tyranron merged commit 681d242 into graphql-rust:master Aug 16, 2024
174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement of existing features or bugfix k::documentation Related to project documentation k::integration Related to integration with third-party libraries or systems lib::bson Related to `bson` crate integration lib::chrono Related to `chrono` crate integration lib::time Related to `time` crate integration semver::breaking Breaking change in terms of SemVer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants