Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration for Jiff date/time types #1271

Merged
merged 13 commits into from
Aug 15, 2024

Conversation

sgoll
Copy link
Contributor

@sgoll sgoll commented Aug 3, 2024

Description

This adds Jiff integration, behind feature flag jiff, for the following date/time types:

This does not add integration for Zoned because there is no matching GraphQL scalar yet. See #1270 (comment) and related comments for details.

Closes #1270

@sgoll
Copy link
Contributor Author

sgoll commented Aug 9, 2024

With 9acbe24, this is now ready for review.

@LegNeato
Copy link
Member

LegNeato commented Aug 9, 2024

I'll take a look in the next couple of days if @tyranron doesn't get to it

@tyranron tyranron added k::integration Related to integration with third-party libraries or systems feature New feature or request lib::jiff Related to `jiff` crate integration labels Aug 15, 2024
@tyranron tyranron added this to the 0.17.0 milestone Aug 15, 2024
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sgoll wow, thank you for the very thoughtful and pedantic PR!

Reviewing it was really a pleasure. Everything is almost perfect. The only few things I've adjusted:

  • removed default features of jiff crate;
  • removed rustdoc intra-links from GraphQL docs of the added scalars.

@tyranron tyranron merged commit 2756260 into graphql-rust:master Aug 15, 2024
174 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request k::integration Related to integration with third-party libraries or systems lib::jiff Related to `jiff` crate integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide support for Jiff date/time types
3 participants