-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration for Jiff date/time types #1271
Conversation
With 9acbe24, this is now ready for review. |
I'll take a look in the next couple of days if @tyranron doesn't get to it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sgoll wow, thank you for the very thoughtful and pedantic PR!
Reviewing it was really a pleasure. Everything is almost perfect. The only few things I've adjusted:
- removed default features of
jiff
crate; - removed rustdoc intra-links from GraphQL docs of the added scalars.
Description
This adds Jiff integration, behind feature flag
jiff
, for the following date/time types:civil::Date
to GraphQL scalarLocalDate
civil::Time
to GraphQL scalarLocalTime
civil::DateTime
to GraphQL scalarLocalDateTime
Timestamp
to GraphQL scalarDateTime
Span
to GraphQL scalarDuration
This does not add integration for
Zoned
because there is no matching GraphQL scalar yet. See #1270 (comment) and related comments for details.Closes #1270