fix: specify GraphQLFieldResolver type to ensure graphql v15 compatibility #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've been investigating a bit more and I think trying to ensure v15 compatibility is futile. There's other types like GraphQLScalarType (#1074) which also added generic types. |
Yeah, ideally it would be but the breaking type signature changes have made it difficult to achieve. It should be at least runtime compatible with v15, but I haven't spent time investigating making it type safe for v15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this type is not specified the generated definition file (plugin.d.ts) includes the four generic types, which makes it incompatible with graphql v15.
Fixes #1073