Fix issue #415: removeMany should not throw an error if deleteCount equal 0 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f deleteCount equal 0 to keep same behavior between mongoose v5 and v6
Codecov ReportBase: 92.54% // Head: 92.54% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #416 +/- ##
=======================================
Coverage 92.54% 92.54%
=======================================
Files 57 57
Lines 2213 2213
Branches 681 681
=======================================
Hits 2048 2048
Misses 163 163
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Good catch and brilliant fix! |
|
🎉 This PR is included in version 9.7.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RemoveMany should not throw an error if deleteCount equal 0 to keep same behaviour with mongoose v5 and v6.
Fix issue #415