Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove minimum allocation duration restriction #902

Merged
merged 7 commits into from
May 13, 2024
Merged

feat: remove minimum allocation duration restriction #902

merged 7 commits into from
May 13, 2024

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Jan 4, 2024 •
edited
Loading

Implementation for https://forum.thegraph.com/t/gip-0060-early-allocation-closure/4559

Changes

  • Staking contract no longer has a minimum duration requirement of one epoch. Allocations can be opened and closed within the same epoch.
  • Allocations that are closed less than one epoch after they were opened will not get indexing rewards even with a valid POI.
  • Indexers should still use 0x00 POI to close allocations opened by mistake, or for subgraphs that were not synced, etc.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented Jan 4, 2024 •
edited
Loading

feat: remove minimum allocation duration restriction

Generated at commit: 08dcc6aa46baef82ae386a3f369645ad72aed667

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
4
0
15
37
58
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@codecov Codecov
Copy link

codecov bot commented Jan 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.69%. Comparing base (59154f7) to head (08dcc6a).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #902      +/-   ##
==========================================
- Coverage   92.70%   92.69%   -0.01%     
==========================================
  Files          46       46              
  Lines        2370     2369       -1     
  Branches      426      425       -1     
==========================================
- Hits         2197     2196       -1     
  Misses        173      173
Flag Coverage Δ
unittests 92.69% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmigone tmigone changed the title feat: remove minium allocation duration restriction feat: remove minimum allocation duration restriction Jan 4, 2024
Maikol
Maikol previously approved these changes Jan 5, 2024
View reviewed changes
pcarranzav
pcarranzav previously approved these changes Jan 5, 2024
View reviewed changes
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@tmigone tmigone dismissed stale reviews from pcarranzav and Maikol via 54af1a7 March 18, 2024 13:21
@tmigone
chore: add audit report
ec3c7cd 
Signed-off-by: Tomás Migone <[email protected]>
@socket-security Socket Security
Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@aws-sdk/[email protected] None 0 20 kB aws-sdk-bot
npm/@babel/[email protected] None 0 65.2 kB nicolo-ribaudo
npm/@babel/[email protected] environment, filesystem, unsafe +1 850 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 493 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.02 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 502 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.56 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 21.6 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 7.03 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 107 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 63.8 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 158 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.66 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 130 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 32.2 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 14.1 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 5.96 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 10.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 31.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 11.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 650 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 1.89 MB nicolo-ribaudo
npm/@babel/[email protected] None 0 3.34 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 2.68 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.14 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 2.53 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 5.55 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.55 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 155 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 160 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 22.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 148 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 44.7 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 6.2 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.63 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.94 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 42.4 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 9.23 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 132 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 4.72 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 12.4 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 80 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 7.11 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 21.2 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 15.9 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 68.9 kB nicolo-ribaudo
npm/@babel/[email protected] None 0 618 kB nicolo-ribaudo
npm/@babel/[email protected] environment 0 2.41 MB nicolo-ribaudo
npm/@cspotcode/[email protected] filesystem +1 194 kB cspotcode
npm/@eslint-community/[email protected] None 0 379 kB eslint-community-bot
npm/@eslint-community/[email protected] None 0 431 kB eslint-community-bot
npm/@fastify/[email protected] None 0 80.2 kB gurgunday
npm/@graphql-typed-document-node/[email protected] None 0 2.96 kB dotansimha
npm/@humanwhocodes/[email protected] unsafe 0 21.2 kB nzakas
npm/@humanwhocodes/[email protected] None 0 23.3 kB nzakas
npm/@isaacs/[email protected] None +4 67.1 kB isaacs
npm/@ljharb/[email protected] None 0 31.7 kB ljharb
npm/@pkgjs/[email protected] None 0 74.2 kB oss-bot
npm/@sindresorhus/[email protected] None 0 40.2 kB sindresorhus
npm/@smithy/[email protected] None 0 233 kB smithy-team
npm/@types/[email protected] None 0 6.45 kB types
npm/@types/[email protected] None 0 192 kB types
npm/@types/[email protected] None 0 25.7 kB types
npm/@types/[email protected] None 0 6.61 kB types
npm/@types/[email protected] None 0 31.7 kB types
npm/@types/[email protected] None 0 12.5 kB types
npm/@types/[email protected] None 0 3.2 kB types
npm/@types/[email protected] None 0 2.95 kB types
npm/@types/[email protected] None 0 3.43 kB types
npm/@types/[email protected] None 0 8.65 kB types
npm/@types/[email protected] None 0 53 kB types
npm/@typescript-eslint/[email protected] None 0 156 kB jameshenry
npm/@ungap/[email protected] None 0 26.2 kB webreflection
npm/[email protected] None 0 24.4 kB rreverser
npm/[email protected] None 0 52.4 kB marijn
npm/[email protected] None 0 531 kB marijn
npm/[email protected] environment, filesystem, shell 0 13 kB fengmk2
npm/[email protected] None 0 34.6 kB tootallnate
npm/[email protected] None 0 9.65 kB phated
npm/[email protected] None 0 5.32 kB jonschlinkert
npm/[email protected] None 0 6.88 kB jonschlinkert
npm/[email protected] None 0 6.66 kB jonschlinkert
npm/[email protected] None 0 3.57 kB sindresorhus
npm/[email protected] None 0 4.43 kB jonschlinkert
npm/[email protected] environment 0 11.4 kB pfmooney
npm/[email protected] None 0 5.85 kB phated
npm/[email protected] None 0 3.4 kB kevva
npm/[email protected] None 0 4.4 kB paulmillr
npm/[email protected] None 0 541 kB hargasinski
npm/[email protected] None 0 27.4 kB alexindigo
npm/[email protected] None 0 36.2 kB coolaj86
npm/[email protected] None 0 14.2 kB mikeal
npm/[email protected] environment 0 23.5 kB hichaelmart
npm/[email protected] network 0 1.84 MB jasonsaayman
npm/[email protected] Transitive: eval +1 73.6 kB hzoo
npm/[email protected] None 0 6.94 kB juliangruber
npm/[email protected] None 0 9.62 kB feross
npm/[email protected] None 0 351 kB mikemcl
npm/[email protected] None 0 5.03 kB sindresorhus
npm/[email protected] environment, filesystem 0 11.2 kB tootallnate
npm/[email protected] environment, filesystem 0 62.8 kB ai
npm/[email protected] None 0 5.05 kB linusu
npm/[email protected] None 0 13.7 kB brianc
npm/[email protected] None 0 91.3 kB feross
npm/[email protected] None 0 2.05 MB caniuse-lite
npm/[email protected] None 0 14.3 kB mikeal
npm/[email protected] environment, filesystem 0 90.2 kB paulmillr
npm/[email protected] filesystem 0 5.71 kB isaacs
npm/[email protected] None 0 5.51 kB sindresorhus
npm/[email protected] None 0 6.14 kB sindresorhus
npm/[email protected] None 0 32.1 kB sindresorhus
npm/[email protected] environment 0 11.5 kB knownasilya
npm/[email protected] None 0 16 kB jongleberry
npm/[email protected] None 0 10.1 kB qix
npm/[email protected] None 0 17 kB jorgebucaran
npm/[email protected] None 0 11.5 kB alexindigo
npm/[email protected] None 0 55.2 kB omichelsen
npm/[email protected] None 0 4.86 kB substack
npm/[email protected] environment, filesystem 0 123 kB pi0
npm/[email protected] None 0 10.5 kB dougwilson
npm/[email protected] None 0 15.9 kB phated
npm/[email protected] None 0 23.2 kB isaacs
npm/[email protected] None 0 31 kB sheetjs
npm/[email protected] network 0 75.1 kB lquixada
npm/[email protected] environment 0 42.4 kB qix
npm/[email protected] None 0 6.09 kB samverschueren
npm/[email protected] None 0 9.19 kB unclechu
npm/[email protected] None 0 8.11 kB thlorenz
npm/[email protected] network 0 5.45 kB szmarczak
npm/[email protected] None 0 8.02 kB apechimp
npm/[email protected] None 0 429 kB explodingcabbage
npm/[email protected] None 0 106 kB eslint
npm/[email protected] None 0 13.6 kB komagata
npm/[email protected] None 0 6.26 kB dougwilson
npm/[email protected] None 0 287 kB kilianvalkhof
npm/[email protected] None 0 6.23 kB mafintosh
npm/[email protected] None 0 10.2 kB sindresorhus
npm/[email protected] None 0 18.1 kB ralphtheninja
npm/[email protected] None 0 16.5 kB medikoo
npm/[email protected] None 0 3.66 kB dougwilson
npm/[email protected] None 0 20.8 kB lydell
npm/[email protected] None 0 32.3 kB eslintbot
npm/[email protected] None 0 1 MB michaelficarra
npm/[email protected] None 0 13.5 kB michaelficarra
npm/[email protected] None 0 37.1 kB michaelficarra
npm/[email protected] None 0 50.6 kB michaelficarra
npm/[email protected] None 0 82.8 kB goto-bus-stop
npm/[email protected] None 0 9.33 kB jonschlinkert
npm/[email protected] None +1 28.1 kB jonschlinkert
npm/[email protected] None 0 37.3 kB sssayegh
npm/[email protected] None 0 23.5 kB ljharb
npm/[email protected] None 0 22.8 kB dap
npm/[email protected] None 0 52.3 kB luin
npm/[email protected] None 0 5.07 kB mafintosh
npm/[email protected] None 0 17 kB esp
npm/[email protected] None 0 9.44 kB hiddentao
npm/[email protected] environment, network, shell 0 11 kB bolinfest
npm/[email protected] None 0 4.35 kB doowb
npm/[email protected] filesystem 0 29.3 kB jaredwray
npm/[email protected] None 0 40.3 kB webreflection
npm/[email protected] network 0 29.4 kB rubenverborgh
npm/[email protected] None 0 6.28 kB jonschlinkert
npm/[email protected] network 0 14 kB simov
npm/[email protected] filesystem, network 0 43.4 kB niftylettuce
npm/[email protected] None 0 9.9 kB jonschlinkert
npm/[email protected] filesystem 0 4.49 kB dead_horse
npm/[email protected] environment, filesystem 0 13.4 kB isaacs
npm/[email protected] None 0 173 kB pipobscure
npm/[email protected] None 0 43.5 kB mikolalysenko
npm/[email protected] None 0 28.9 kB loganfsmyth
npm/[email protected] filesystem 0 55.1 kB isaacs
npm/[email protected] environment 0 6.57 kB jonschlinkert
npm/[email protected] environment, filesystem 0 8.27 kB jonschlinkert
npm/[email protected] None 0 3.47 kB raynos
npm/[email protected] None 0 39.8 kB sindresorhus
npm/[email protected] None 0 812 kB mattpauldavies
npm/[email protected] None 0 1.34 MB i1g
npm/[email protected] None 0 15.1 kB ahmadnassri
npm/[email protected] None 0 3.02 kB tarruda
npm/[email protected] None 0 41.7 kB indutny
npm/[email protected] None 0 124 kB mathias
npm/[email protected] network 0 48.4 kB arekinath
npm/[email protected] network 0 26 kB tootallnate
npm/[email protected] None 0 6.8 kB feross
npm/[email protected] None 0 11.9 kB jensyt
npm/[email protected] None 0 3.76 kB isaacs
npm/[email protected] None 0 20.3 kB ljharb
npm/[email protected] None 0 3.08 kB sindresorhus
npm/[email protected] None 0 4.59 kB feross
npm/[email protected] None 0 18.8 kB ljharb
npm/[email protected] filesystem 0 3.01 kB sindresorhus
npm/[email protected] None 0 4.12 kB sindresorhus
npm/[email protected] None 0 7.5 kB jonschlinkert
npm/[email protected] None 0 4.41 kB hughsk
npm/[email protected] None 0 3.54 kB sindresorhus
npm/[email protected] environment, filesystem 0 3.76 kB sindresorhus
npm/[email protected] None 0 6.93 kB doowb
npm/[email protected] None 0 13.3 kB rvagg
npm/[email protected] environment 0 253 kB isaacs
npm/[email protected] None 0 45.8 kB andyperlitch
npm/[email protected] None 0 32 kB mathias
npm/[email protected] None 0 5.4 kB dominictarr
npm/[email protected] None 0 14.2 kB samn
npm/[email protected] None 0 12.7 kB isaacs
npm/[email protected] None 0 235 kB jordanbtucker
npm/[email protected] None 0 27.8 kB jaredwray
npm/[email protected] None 0 24.9 kB gkz
npm/[email protected] None 0 26.5 kB jdalton
npm/[email protected] None 0 19.8 kB jdalton
npm/[email protected] environment 0 5.81 kB zertosh
npm/[email protected] None 0 39.2 kB rsms
npm/[email protected] None 0 7.6 kB jonschlinkert
npm/[email protected] None 0 12 kB wooorm
npm/[email protected] None 0 206 kB dougwilson
npm/[email protected] None 0 18.3 kB dougwilson
npm/[email protected] environment, filesystem 0 51.7 kB broofa
npm/[email protected] None 0 3.58 kB sindresorhus
npm/[email protected] None 0 54.9 kB raynos
npm/[email protected] None 0 1.55 kB cwmma
npm/[email protected] None 0 285 kB isaacs
npm/[email protected] filesystem 0 7.69 kB isaacs
npm/[email protected] None 0 6.51 kB isaacs
npm/[email protected] None 0 429 kB kkoopa
npm/[email protected] None 0 24.4 kB ai
npm/[email protected] None 0 5.65 kB megawac
npm/[email protected] None 0 298 kB suguru03
npm/[email protected] None 0 16.3 kB broofa
npm/[email protected] None 0 34 kB chicoxyzzy
npm/[email protected] None 0 9.22 kB jonschlinkert
npm/[email protected] None 0 13.8 kB simov
npm/[email protected] None 0 5.49 kB sindresorhus
npm/[email protected] None 0 7.92 kB jonschlinkert
npm/[email protected] None 0 6.36 kB phated
npm/[email protected] None 0 4.05 kB isaacs
npm/[email protected] None 0 50.2 kB gkz
npm/[email protected] None 0 3.11 kB sindresorhus
npm/[email protected] None 0 10 kB brianc
npm/[email protected] None +1 16.1 kB jonschlinkert
npm/[email protected] None 0 3.62 kB sindresorhus
npm/[email protected] None 0 4.79 kB jonschlinkert
npm/[email protected] filesystem +1 1.21 MB isaacs
npm/[email protected] None 0 11.3 kB meryn
npm/[email protected] filesystem 0 9.1 kB brianc
npm/[email protected] None 0 3.19 kB charmander
npm/[email protected] None 0 188 kB brianc
npm/[email protected] None 0 2.58 kB floatdrop
npm/[email protected] None 0 6.97 kB jonschlinkert
npm/[email protected] None 0 4.9 kB bendrucker
npm/[email protected] None 0 3.06 kB bendrucker
npm/[email protected] None 0 5.92 kB bendrucker
npm/[email protected] None 0 36.7 kB gkz
npm/[email protected] None 0 2.98 kB sindresorhus
npm/[email protected] None 0 9.42 kB jonschlinkert
npm/[email protected] None 0 9.58 kB bpscott
npm/[email protected] None 0 3.17 kB cwmma
npm/[email protected] None 0 15.3 kB cwmma
npm/[email protected] environment 0 29.5 kB rob-w
npm/[email protected] None 0 461 kB lupomontero
npm/[email protected] filesystem 0 7.78 kB mafintosh
npm/[email protected] None 0 126 kB ljharb
npm/[email protected] None 0 6.36 kB cwmma
npm/[email protected] filesystem 0 20.5 kB paulmillr
npm/[email protected] None 0 49.2 kB mathias
npm/[email protected] None 0 9.88 kB doowb
npm/[email protected] None 0 8.46 kB jonschlinkert
npm/[email protected] None 0 4.25 kB darsain
npm/[email protected] None 0 5.39 kB jonschlinkert
npm/[email protected] None 0 9.09 kB jonschlinkert
npm/[email protected] None 0 17.9 kB fent
npm/[email protected] None 0 25.2 kB matteo.collina
npm/[email protected] None 0 6.6 kB sboudrias
npm/[email protected] None 0 4.5 MB blesh
npm/[email protected] None 0 5.87 kB substack
npm/[email protected] None +1 58.3 kB qix
npm/[email protected] None 0 34.3 kB lydell
npm/[email protected] None 0 805 kB tromey
npm/[email protected] None +1 22.4 kB jonschlinkert
npm/[email protected] None 0 6.96 kB sindresorhus
npm/[email protected] None 0 11 kB substack
npm/[email protected] None 0 3.5 kB sindresorhus
npm/[email protected] None 0 2.79 kB sindresorhus
npm/[email protected] network 0 86.6 kB jstash
npm/[email protected] None 0 268 kB sebmaster
npm/[email protected] None 0 828 kB joshuakgoldberg
npm/[email protected] environment, network 0 16.7 kB mikeal
npm/[email protected] None 0 21.2 kB gkz
npm/[email protected] None 0 42.1 kB chaijs
npm/[email protected] None 0 8.84 kB feross
npm/[email protected] environment, eval, filesystem 0 1.28 MB alexlamsl
npm/[email protected] None 0 4.93 kB tunnckocore
npm/[email protected] environment, network, unsafe 0 1.17 MB matteo.collina
npm/[email protected] environment 0 14 kB ai
npm/[email protected] None 0 9.51 kB jonschlinkert
npm/[email protected] None 0 116 kB ctavan
npm/[email protected] None 0 9.04 MB mattiasbuelens
npm/[email protected] None 0 12.4 kB sebmaster
npm/[email protected] None 0 49.9 kB domenic
npm/[email protected] None 0 11.8 kB jonschlinkert
npm/[email protected] None 0 36.8 kB substack
npm/[email protected] None 0 2.96 kB zkat
npm/[email protected] None 0 6.46 kB raynos
npm/[email protected] environment 0 448 kB eemeli
npm/[email protected] None 0 666 kB colinmcd94

🚮 Removed packages: npm/@0no-co/[email protected], npm/@ampproject/[email protected], npm/@arbitrum/[email protected], npm/@babel/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@changesets/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@commitlint/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@ethersproject/[email protected], npm/@manypkg/[email protected], npm/@manypkg/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/@types/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected], npm/[email protected]

View full report↗︎

@socket-security Socket Security
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSource
Install scripts npm/[email protected]
  • Install script: install
  • Source: node install.js

View full report↗︎

Next steps

What is an install script?

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

@tmigone tmigone merged commit eb910f0 into main May 13, 2024
9 of 10 checks passed
@tmigone tmigone deleted the tmigone/allow-early-closure branch May 13, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Maikol Maikol Maikol approved these changes

@pcarranzav pcarranzav pcarranzav left review comments

Assignees
No one assigned
Labels
audited protocol change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmigone @pcarranzav @Maikol