Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing parameters to deploy script and reduced runs to 50 for SubgraphService #1062

Open
wants to merge 2 commits into
base: horizon
Choose a base branch
from

Conversation

Maikol
Copy link
Member

@Maikol Maikol commented Oct 17, 2024

Run gas profile for both options and saving for 200 runs was:

SubgraphService:
  acceptProvisionPendingParameters: 693 gas saved
  collect: 1,405 gas saved
  initialize: 991 gas saved
  startService: 914 gas saved
  stopService: 295 gas saved

DisputeManager:
  acceptDispute: 248 gas saved
  cancelDispute: 66 gas saved
  createIndexingDispute: 469 gas saved
  createQueryDispute: 481 gas saved
  initialize: 387 gas saved

Copy link

openzeppelin-code bot commented Oct 17, 2024

fix: added missing parameters to deploy script and reduced runs to 50 for SubgraphService

Generated at commit: a256d749275900dba4ea9b2f29c0e569e148e4ae

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
4
0
15
40
61
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@@ -13,7 +13,7 @@ const config: HardhatUserConfig = {
settings: {
optimizer: {
enabled: true,
runs: 200,
runs: 50,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is also set in graphprotocol/contracts/packages/subgraph-service/foundry.toml. Not sure if they are meant to be kept in-sync...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah yes, thank you! I changed it back to 200 to get the gas report and forgot to switch it back

@tmigone tmigone force-pushed the mde/horizon-and-subgrah-service-deploy-fix branch from ba40a74 to a256d74 Compare November 14, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants