fix: tweaks to thawing pool management

[tmigone]

A few notes:

Provision

• Thawing pool reset condition is tokensThawing == 0 (empty pool)
• When a provision is fully slashed any ongoing thawing is cancelled
  • sharesThawing is set to 0
  • a nonce tied to the thawing pool is incremented, this invalidates existing thaw requests which in practice means when they are fulfilled they get 0 tokens.

Delegation Pool

• Delegation pool reset conditions are:
  • tokens ==0 && shares ==0 (empty pool) or tokens == thawingTokens (pool fully thawing)
• When a delegation pool is fully slashed any ongoing thawing is cancelled
  • sharesThawing is set to
  • nonce incremente to invalidate thaw requests
• Delegation pool invalid state
  • When the pool state is tokens == 0 && shares != 0 as a result of a delegation pool being fully slashed
  • Pool can be recovered by using addTokensToDelegationPool(). This is the only delegation pool action that can be performed on invalid state pools
  • Delegators with shares thawing at the moment the pool gets to the invalid state loose their thawing shares and are not given delegation pool shares in return (they are all worth 0 tokens aynways)

[openzeppelin-code]

fix: tweaks to thawing pool management

Generated at commit: 1b3263abe2c3e4c5f336955f66fc704f757d0578

🚨 Report Summary

	Severity Level	Results
Contracts	Critical High Medium Low Note Total	2 4 0 15 40 61
Dependencies	Critical High Medium Low Note Total	0 0 0 0 0 0

---

For more details view the full report in OpenZeppelin Code Inspector

[Maikol]

Looks good to me 🥇

[pcarranzav]

LGTM 🎸