fix: pool timeout bug #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neriumrevolta
force-pushed
the
petko/fix-pool-timeout-bug
branch
3 times, most recently
from
3278723
to
30b9bfd
Compare
Closed
|
switching to draft until I fix these damn CI issues |
neriumrevolta
force-pushed
the
petko/fix-pool-timeout-bug
branch
3 times, most recently
from
a4b6ab2
to
1a10c2f
Compare
neriumrevolta
force-pushed
the
petko/fix-pool-timeout-bug
branch
from
1a10c2f
to
380b31d
Compare
hopeyen
approved these changes
Mar 15, 2024
| @@ -185,10 +185,12 @@ impl RadioOperator { | |||
| }; | |||
| } | |||
|
|
|||
| let batch_size = 1000; | |||
There was a problem hiding this comment.
how was this size determined? would like to understand if this is a magic number or if you had some analysis on the optimal size; either way would appreciate a comment in code
There was a problem hiding this comment.
magic number really :> i take recommendations but it seemed like an ok batch size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
count_messagesresolverprune_old_messagesmore efficientcomparison_intervaltosummary_intervalto match what the function is doing a bit better, also increased the interval to 180 secondscount_messagesinstead oflist_messagesin summary function