Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: boot node connections #292

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix: boot node connections #292

merged 1 commit into from
Oct 4, 2023

Conversation

pete-eiger
Copy link
Contributor

@pete-eiger pete-eiger commented Oct 3, 2023 •
edited
Loading

Description

Fixes:

  • Disconnect from peers that don't support protocols we need (might need more customisability here, but since our peer id is not in the peers list, getting our local node's protocols isn't that straightforward, we'd need to check the config vars)
  • Re-connect only to nodes that support protocols we need
  • When sending messages, try sending only to connected peers
  • Turning off waku nodes by default (setting level to Panic), they are way too noisy

@pete-eiger pete-eiger self-assigned this Oct 3, 2023
@pete-eiger pete-eiger force-pushed the petko/boot-node-connections branch 3 times, most recently from 498a5b2 to 08012d0 Compare October 3, 2023 16:33
hopeyen
hopeyen reviewed Oct 3, 2023
View reviewed changes
examples/ping-pong/src/main.rs Outdated Show resolved Hide resolved
examples/ping-pong/src/main.rs Outdated Show resolved Hide resolved
src/graphcast_agent/waku_handling.rs Outdated Show resolved Hide resolved
@pete-eiger pete-eiger force-pushed the petko/boot-node-connections branch 4 times, most recently from 1722cc1 to f65597a Compare October 4, 2023 12:21
@pete-eiger pete-eiger linked an issue Oct 4, 2023 that may be closed by this pull request
Messages not being sent/received #291
Closed
hopeyen
hopeyen approved these changes Oct 4, 2023
View reviewed changes
src/graphcast_agent/mod.rs Show resolved Hide resolved
@pete-eiger pete-eiger merged commit ce9f5d3 into dev Oct 4, 2023
12 checks passed
@pete-eiger pete-eiger deleted the petko/boot-node-connections branch October 4, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hopeyen hopeyen hopeyen approved these changes

Assignees

@pete-eiger pete-eiger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Messages not being sent/received
2 participants
@pete-eiger @hopeyen