Candidate entities for scoring in pipeline #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjust
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to allow restricting scoring in
AllScoresPipelineto a specific set of candidate heads/tails provided by the user. This implies that all predicted entities for completions are within this particular set.TODO: it would be more efficient to just compute the scores for these candidate entities, instead of scoring everything and then masking the scores for entities not in the candidate set. This requires tweaking the
AllScoresBESSmodule, supporting a customcandidate_sampler. In the case where we also want to filter triples, the filter generation would also need to be adjusted.