Track original triple IDs in KGDataset.from_triples #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danjust
reviewed
Jan 8, 2024
besskge/dataset.py
Outdated
| n_entity=data[:, [0, 2]].max() + 1, | ||
| n_relation_type=data[:, 1].max() + 1, | ||
| entity_dict=entity_dict, | ||
| relation_dict=relation_dict, | ||
| type_offsets=type_offsets, | ||
| triples=triples, | ||
| ) | ||
| ds.original_triple_ids = triple_ids # type: ignore |
There was a problem hiding this comment.
It might be more consistent for downstream analytics if original_triple_ids always was a member of the dataset. I'd add a dict with values arange(...) if the dataset is not created through from_triples
There was a problem hiding this comment.
Agree, good point, thanks! I should have added this to every constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating datasets with random train/valid/test splitting with
KGDataset.from_triplesandKGDataset.from_dataframe, for downstream tasks (e.g. comparing predictions with edge graph statistics) it can be useful to keep track of the shuffling and splitting of the original triple IDs in the(n_triple, 3)array/df.