Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

only ipu cos sin in fp16 #32

Merged
merged 1 commit into from
Oct 20, 2023
Merged

only ipu cos sin in fp16 #32

merged 1 commit into from
Oct 20, 2023

Conversation

danjust
Copy link
Contributor

@danjust danjust commented Oct 20, 2023

cos/sine have no fp16 implementation on CPU, therefore casting should only happen on IPU

@danjust danjust requested a review from AlCatt91 October 20, 2023 10:49
AlCatt91
AlCatt91 approved these changes Oct 20, 2023
View reviewed changes
Copy link
Collaborator

@AlCatt91 AlCatt91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@danjust danjust merged commit 1086c6c into main Oct 20, 2023
1 check passed
@danjust danjust deleted the cpu_sin_cos branch October 20, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlCatt91 AlCatt91 AlCatt91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danjust @AlCatt91