Fix list size option in the top surnames gramplet #1780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bug #13448 |
|
@DaveSch-gramps Do you have Black installed locally? Running that on the source file will eliminate the lint check failure. |
|
No to Black. I am not a real coder. I modified code I found in LastModified to achieve the menu options. I just use Github Desktop for Windows and Atom. I do understand Atom is no longer supported. |
No worries. Looks like Black would like to see two empty lines after `NUM_SURNAMES =" and there's only one right now. Simple fix. |
|
Line added and both checks are green! |
Allow users to specify how many surnames appear in the list from 10 to 1000 Fixes #13448
Nick-Hall
changed the title
Nick-Hall
force-pushed
the
Topsurname-config
branch
from
7de3777 to
af88f33
Compare
Nick-Hall
merged commit af88f33
into
gramps-project:maintenance/gramps52
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow users to specify how many surnames appear in the list from 10 to 1000
from discourse
https://gramps.discourse.group/t/diversely-transliterated-sur-names-and-statistics/5768/8