Simplify some Cairo drawing #1671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
force-pushed
the
simplify-draws
branch
2 times, most recently
from
dc52a25 to
75245cc
Compare
|
@QuLogic Love all your enhancements. How do we validate the changes? |
|
For the fan charts, you can just open them like normal, and they should not have changed (except the strokes on the child rings). For the map markers, I'm actually not sure how to get the maps to use the coloured markers. I just edited the view files and forced it to use a hard-coded colour instead of the stock image while testing. |
Instead of generating paths twice, once for filling and once for stroking, use the path-preserving `fill_preserve` operator instead. As well, do the filling before stroking for consistency, or else the stroke might be accidentally covered, as occurred with the child rings. Also, simplify the map marker which seems to have drawn the elliptical portion twice.
Nick-Hall
force-pushed
the
simplify-draws
branch
from
75245cc to
3442876
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of generating paths twice, once for filling and once for stroking, use the path-preserving
fill_preserveoperator instead. As well, do the filling before stroking for consistency, or else the stroke might be accidentally covered, as occurred with the child rings.Also, simplify the map marker which seems to have drawn the elliptical portion twice.