Make subprocess inherit environment variables #1638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PATH environment variable got unset for that subprocess, thus not being able to find msgfmt.
|
Rebased onto gramps52. |
Nick-Hall
merged commit d6a9b40
into
gramps-project:maintenance/gramps52
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to build the latest beta versions of the package, but I got an error coming from the
merge(...)function insetup.pyIt turns out, a call to
msgfmtwas setting an environment variable without inheriting the current environment variables. Because of this, thePATHenvironment variable got unset for that subprocess, thus not being able to findmsgfmt.Luckily, I found a quick fix for it.