Add a name parameter to the get_person_mark utility #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows an alphabetical index entry for a person to use the selected name format. Previously a "Surname, Given Suffix" format was always used. Fixes #13155.
|
Is the "needed for Arabic" annotation used everywhere in the code? Or is it a mix of notations using a generic "RTL" and others with specific languages? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows an alphabetical index entry for a person to use the selected name format. Previously a "Surname, Given Suffix" format was always used.
Fixes #13155.
A quick grep reveals that about a dozen reports are affected.
Another possible solution would be to pass a name displayer to the
get_person_markutility rather than a name. This needs further investigation. I don't have time right now.