Show other roles for an event in the narrative web report #1633
Conversation
|
How timely! A user asked for a comparable enhancement to show all Shared Event participants in the Complete Individual Report on Discourse https://gramps.discourse.group/t/shared-events-and-participants-reporting/4712 |
|
Hi Vincent. |
|
There is a discussion about how to introduce non-programmers to Pull Requests in GitHub. There is a 1st draft describing how the patches can be applied to the Gramps on their local machine : https://gramps.discourse.group/t/create-guidance-document-for-users-about-patching/4699 |
|
It will not work on a gramps 5.1 |
|
It does not work for me. File "/home/gramps/pull-gramps-1/gramps/plugins/webreport/basepage.py", line 929, in display_event_row |
|
You added a new page name "other roles". Another thing:
by |
|
I have removed the lines in 1897 and 2078. That was a copy/paste error on my side. The problem on line 927 is different. I only considered events on persons and not on families. Your fix "and not omit" is not correct. I'm working on a better fix that will work. |
Yes, it is the only solution for that problem. The omit variable is set only in the family page. I tested on my database with 15000 persons, 23000 events and 5200 families. No crash and I have the other roles for the persons. |
|
Thanks Serge your fix worked for me by tree is about the same size as yours |
Do you want to add "other roles" for familes events ? |
Yes, that's what I'm working on. |
|
OK so where I am now the Report is working, I now have a Tab for other roles ( which generates the error "file not found" which is to be expected) and I can see other roles when I go into either of Individuals or Surnames. Could I ask what is the logic by behind extending to Families when by definition "another role" is an individual who is present at the Event of a second individual. I am not saying it would not be valid I am just trying to get my head round the concept. |
|
I just pushed some commits. The tab "Other roles" is now removed. A Person can have events (with a role) and a Family can also have events (with a role). That means that an event can be referenced by a Person or a Family. My goal is to extend everywhere where an event is shown (PersonPage and FamilyPage), to also show the other objects (Person or Family) that also have a role in that event. |
|
Hi Vincent
Still cannot conceive any actual event where a Family as group will have
a role in an individuals life. Or do you just consider Mother & Father
as the Family Group.
Maybe as group of individuals attending a significant birthday or similar.
Will sort "other roles" Tab
Thanks
Phil
…On 24/01/2024 17:28, Vincent Smeets wrote:
I just pushed some commits. The tab "Other roles" is now removed.
A Person can have events (with a role) and a Family can also have events (with a role). That means that an event can be referenced by a Person or a Family.
My current commit can only show multiple roles for a person on a PersonPage. On that PersonPage, it will not show any families that also have a role in that same event.
My goal is to extend everywhere where an event is shown (PersonPage and FamilyPage), to also show the other objects (Person or Family) that also have a role in that event.
|
|
In general, Family secondary objects are things that apply to both spouses (not the Family's children or one spouse) in equal measure as "Primaries" So they are good for a report/article that might list "Mr. and Mrs. John and Mary Smith" ... or "Dr. and Mrs. Jones". Both are considered as 'Primary' without the hassles of endless sharing. |
|
Hi
OK can take that but it occurs so infrequently in my world that it is
not a priority not even on the to do list.
Phil
…On 24/01/2024 19:58, Emyoulation or BAMaustin wrote:
In general, Family secondary objects are things that apply to both spouses (not the Family's children or one spouse) in equal measure as "Primaries"
So they are good for a report/article that might list "Mr. and Mrs. John and Mary Smith" ... or "Dr. and Mrs. Jones". Both are considered as 'Primary' without the hassles of endless sharing.
|
|
I'm surprised at that. Some people only use Family for Events that change the relationship: engagement, marriage, divorce, et cetera. But when you consider Gallery, Notes, Sources; it is a lot broader. And then there are Residences, Property and such where to don't want doubling of pins on the Maps. |
|
Hi
I have no problem with that approach, however engagement and divorce are
relatively modern events and certainly I have never come across any
record of engagements in my family other than those that occurred in my
living memory, and divorce is rare or again at least in my family so not
my preferred route, I do not geolocate residencies I could spend the
rest of my life doing the existing properties I have listed and nothing
else so I only locate churches and places of Burial, Baptism and
Marriage, Birth if occuring in hospital.
Phil
…On 24/01/2024 20:07, Emyoulation or BAMaustin wrote:
I'm surprised at that. Some people only use Family for Events that change the relationship: engagement, marriage, divorce, et cetera.
But when you consider Gallery, Notes, Sources; it is a lot broader. And then there are Residences, Property and such where to don't want doubling of pins on the Maps.
|
This is how you should do. These are not person events. |
|
Hi Serge
I think on this one we will have to agree to differ and leave it at that
Phil
…On 25/01/2024 13:06, Serge Noiraud wrote:
> I'm surprised at that. Some people only use Family for Events that change the relationship: engagement,
> marriage, divorce, et cetera.
This is how you should do. These are not person events.
|
|
For me you are wrong and this is how gramps is working. |
|
Hi Serge
I have no problem with your version it is just not the way I think of it
Yes GRAMPS automatically creates Family Events but I never use that View
An Event is something that happens with an outcome so, a birth a child
is born, a death somebody ceases to exist, a marriage one participant
usually female changes their surname (well in pre woke western culture)
at least.
I am legally entitled in the UK to call myself whatever I want as long
it is not for criminal purposes. So me going out on the street and
announcing to the world my name is John Smith is that a marriage.
For me that is the beauty and drawback of the English language it
changes frequently and every word/phrase can have different meanings at
different times.
Examples the word "gay"
That man is very gay means or meant happy
That man is gay means or meant homosexual
That shirt is gay means a fashion mistake (polite version)
A marriage may or may not create a family in the old nuclear style.
A family may or may not consist of a group of individuals who have gone
through a legal ceremony and produced children.
I think maybe this is as far as I would like to go and think this thread
should end.
GRAMPS works for both of us
Phil
…On 25/01/2024 16:00, Serge Noiraud wrote:
For me you are wrong and this is how gramps is working.
A family start with a marriage event and end with either a divorce either the death of one of the two partners.
If you have a divorce then the two same partners remarry, you must create a second marriage with the new marriage event.
etc...
|
Yes. We inherited this functionality from Gedcom. When a Family is a participant in an event, the participants are the two people in the relationship. These events will typically be relationship events and the Family will have the role of "Family". This indicates that the role of the two people in the family is primary. Although it is possible, I can't see a use for adding more than one family to an event, or setting the role for a Family to anything other than "Family". Does anyone do this? It is also possible to add two people to a marriage event with the roles "Husband" and "Wife". Using this approach is likely to cause problems and is not recommended. |
|
I have rewritten the code. It now works correctly on the person page and the family page. It shows for every event also the other percipitence (person or family) dat have some role in the event. The lint check failed on my last commit. It complains about files that I haven't touched. The files I touch are correctly formatted. To me, this PR is ready to be merged. |
Don't worry about this. I'll fix it. |
|
Rebased. |
|
I've patched my system and run the web report against my data entered via forms. No hiccups and the changes address some of my wishes. A couple of observations: What is the purpose of the list of roles in each individual events section? Where a hyperlink exists it take the user to an individual's page rather that the event where the individual's role is detailed. Whilst I appreciate that this may be beyond the scope of the submitter's use case, it would be invaluable if other actors in the event where an individual had a role were also reported, together with associated attributes as is the case for marriage events. |
|
Hi @drjimbouk, To your questions:
|
|
Hi Vincent,
Thanks for the clarification re: list of roles and hyperlink capability. It will still be of use to me as envisaged.
Wrt other actors + attributes. I was thinking along the lines of the marriage event person attributes as currently reported.
Another example might be associated actors in a census event + the same attributes as reported for the principal actor.
Hopefully, someone can pick up the baton and extend what you have achieved.
JS
From: Vincent Smeets ***@***.***>
Sent: 24 April 2024 19:10
To: gramps-project/gramps ***@***.***>
Cc: drjimbouk ***@***.***>; Mention ***@***.***>
Subject: Re: [gramps-project/gramps] webreport.BasePage: Show other roles for an event. (PR #1633)
Hi @drjimbouk <https://github.com/drjimbouk> ,
To your questions:
* What is the purpose of the list of roles in each individual events section?
There can be multiple people that have some role in an event. For a baptising, the primary person is the one that is baptized. There can be some other people that were a witniss to the event. They can all be linked to the same event.
When a family is moving to an other place, then you can assign all the persons of the family as having a primary role in that event. They all move to the new place.
* Where a hyperlink exists it take the user to an individual's page rather that the event where the individual's role is detailed.
There is no page that shows only a single event. So it is not possible to link to such a page. I had no intend to create such an event page.
The show the other people that have a role in that same event. The name of the other person contains a link to the page of that person. There you will see the same event, but then viewed from that other person.
* ... together with associated attributes
What additional assiciated attribute are you expecting? It is not wise to add too much information (birthday, ...) to the names of the other persons. It would cluther the table with unrelated (to the primary person) information.
—
Reply to this email directly, view it on GitHub <#1633 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/AKB27O5HEGB43VHQTKCOUV3Y67YP3AVCNFSM6AAAAABCD7ZAJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZVGU2DINJWGQ> .
You are receiving this because you were mentioned. <https://github.com/notifications/beacon/AKB27O5Z65Y3V5B5C2WNGYDY67YP3A5CNFSM6AAAAABCD7ZAJ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT3WZF7I.gif> Message ID: ***@***.*** ***@***.***> >
|
|
@SNoiraud Is this PR ready to merge? |
I did not test it because I don't use this kind of feature. |
Nick-Hall
changed the title
Include an option to the Narrative Web Page generator to also include other roles for an event.
A person can have multiple events. The events where the person is the primary person, are normally shown in the report. With the additional option "Include other roles" enabled (default disabled), the report will also show the persons that also have some role in that event.
The result looks like this:
