Fix command line progress output #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nick-Hall
force-pushed
the
pr/cli.User
branch
from
4784c58 to
fdbd78b
Compare
The text was partly overwritten whenever the percent value was updated. This commit fixes it in a way that the percent value and text are now correctly aligned.
Nick-Hall
force-pushed
the
pr/cli.User
branch
from
fdbd78b to
7b15d5d
Compare
Nick-Hall
changed the title
|
Added unit tests and rebased onto gramps52. |
Nick-Hall
force-pushed
the
pr/cli.User
branch
from
7b15d5d to
b985108
Compare
These test both percentage steps and a spinner where the number of steps is unknown.
Nick-Hall
force-pushed
the
pr/cli.User
branch
from
b985108 to
60041f3
Compare
Nick-Hall
merged commit 163d88b
into
gramps-project:maintenance/gramps52
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During CLI invocation (e.g.: gramps --action=report ...) a progress is shown on stdout. This progress consists of a procent value and some text. The text is however partly overwriten whenever the percent value is updated.
This PR fixes it in a way that the percent value and text are correctly alligned.