Update and fix CSV import

[dsblank]

This might be too late for gramps52, but this does fix the bug (overwrites firstname) and adds tags to all import types (in CSV), both mentioned in:

https://gramps.discourse.group/t/how-can-people-be-deleted-according-to-a-list/4511/13?u=dsblank

It is ok to apply to master.

[dsblank]

Looks like I broke a test. Fixing...

[emyoulation]

May I ask why the CSV parser allows adding a Source, but not a Citation? (Or maybe it does and the Wiki overlooks documenting it?)

[emyoulation]

Is it possible that the import was originally intended to parse a Full Name ("Surname, Given name")? If so, that would be a useful functionality to keep.

The date is passed through the Date string validator. Perhaps the Place was expected to be a Place Title? From before the Place hierarchy was implemented.

[dsblank]

Is it possible that the import was originally intended to parse a Full Name ("Surname, Given name")?

No, I don't think I ever allowed that as it would be too complicated considering this is CSV.

May I ask why the CSV parser allows adding a Source, but not a Citation?

I can add that in the future if it isn't urgent for now.

The date is passed through the Date string validator. Perhaps the Place was expected to be a Place Title? From before the Place hierarchy was implemented.

Is there a bug related to this?

[emyoulation]

No bug. It works fine. Just trying to discover the design approach. So I can determine whether it makes more sense to leverage it... or to embed functions if it is likely to evolve in an opposite direction.

[dsblank]

May I ask why the CSV parser allows adding a Source, but not a Citation?

Looking at the code, I guess for simplicity (or was just based on my workflow). It does create a default citation, but doesn't allow you to use an existing one, or to provide values.

[dsblank]

All tests passing now.

[emyoulation]

Looking at the code, I guess for simplicity (or was just based on my workflow). It does create a default citation, but doesn't allow you to use an existing one, or to provide values.

My common case when flowing data from a source via CSV is that they share the same citation. i.e., all the data was transcribed from pages 7-12 of that source.

So maybe there could be an option to create a single shared citation for the source as an alternative to serialized citations?

(A workaround is to use the Isotammi addon : MultiMergeGramplet immediately after import. Sort the Citation by modify date, select all the ones in the right time frame, and Merge selected using the Citations sidebar MultiMergeGramplet.)

[dsblank]

So maybe there could be an option to create a single shared citation for the source as an alternative to serialized citations?

Good idea! I'll do this for an updated 5.2 once it is out.

[emyoulation]

please add 'tags' into the recognized headers. This is what is used for export.

It outputs a CSV string. e.g. "ToDo, Complete, Imported 2024/01/11 10:18:02, Another tag"

Import by relabeling the 'Tags' to "tag" creates Tag named for the various combination. Such as named "ToDo, Complete, Imported 2024/01/11 10:18:02, Another tag" and "ToDo, Another tag"