Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification Tool - 8 more rules + performance enhancements #1574

Merged

Conversation

OlliL
Copy link
Contributor

@OlliL OlliL commented Sep 6, 2023

  • Add 8 additional rules:
    • test if the person has events in wrong order
    • test if the family has events in wrong order
    • test if the person has events with role Unknown
    • test if the family has events with role Unknown
    • test if the persons families are ordered incorrectly
    • test if children are ordered incorrectly within a family
    • test if a person's burial date is too late
    • test if a person's baptism date is too late considering family tradition
  • Enhance performance by optimizing the caching-logic and change the order how people and families are process to maximize cache hits.

@Nick-Hall Nick-Hall added this to the v5.2 milestone Sep 6, 2023
@Nick-Hall Nick-Hall force-pushed the maintenance/gramps52 branch from 7748e18 to 6892169 Compare September 8, 2023 19:22
@Nick-Hall
Copy link
Member

Fixed the remaining garbage collection issues.

The get_message method of four family rules was being set to father_message or mother_message. This was preventing garbage collection when the rules failed. I have set self.get_message = None to avoid this.

When fixing this, I noticed that the rules were being recreated for each person/family. This appears inefficient and may be worth investigating in the future.

There was a similar garbage collection issue with the UpdateCallback class used to update the progress bar. I set the update method to None after the rules are run to fix this.

@Nick-Hall Nick-Hall merged commit f45e6f3 into gramps-project:maintenance/gramps52 Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants