Skip to content

Commit

Permalink
Fix display of gramplet help URLs that start with "https://"
Browse files Browse the repository at this point in the history
A help_url starting with either "http://" or "https://" should
be used as the full url to be displayed in the browser.

Fixes #13039.
  • Loading branch information
Nick-Hall committed Feb 6, 2024
1 parent 954cc38 commit dd788e2
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion gramps/gui/widgets/grampletbar.py
Original file line number Diff line number Diff line change
Expand Up @@ -746,7 +746,7 @@ def handle_response(self, object, response):
elif response == Gtk.ResponseType.HELP:
# translated name:
if self.gramplet.help_url:
if self.gramplet.help_url.startswith("http://"):
if self.gramplet.help_url.startswith(("http://", "https://")):
display_url(self.gramplet.help_url)
else:
display_help(self.gramplet.help_url)
Expand Down
2 changes: 1 addition & 1 deletion gramps/gui/widgets/grampletpane.py
Original file line number Diff line number Diff line change
Expand Up @@ -288,7 +288,7 @@ def handle_response(self, object, response):
elif response == Gtk.ResponseType.HELP:
# translated name:
if self.gramplet.help_url:
if self.gramplet.help_url.startswith("http://"):
if self.gramplet.help_url.startswith(("http://", "https://")):
display_url(self.gramplet.help_url)
else:
display_help(self.gramplet.help_url)
Expand Down

0 comments on commit dd788e2

Please sign in to comment.