Use credentials to request manifest.json file #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to properly fetch the manifest.json file when Gramps runs behind an authenticating proxy like Pomerium or Cloudflare Zero Trust, as documented here: https://web.dev/articles/add-manifest#link-manifest
|
Makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to properly fetch the manifest.json file when Gramps runs behind an authenticating proxy like Pomerium or Cloudflare Zero Trust, as documented here: https://web.dev/articles/add-manifest#link-manifest
Without that the request for the manifest.json file is done without the cookies set by the proxy (CF_AppSession and CF_Authorization in the case of Cloudflare) and the request gets redirected to the proxy login page.
As you can guess, I'm running Gramps behind Cloudflare Zero Trust (and Pomerium before that). I'm running into some issues that I am still investigating, but this one seemed simple enough to solve.