Allow editing event type (fixes #146)

gramps-project · Oct 19, 2023 · 68909b4 · 68909b4
1 parent ef1e0ea
commit 68909b4
Show file tree

Hide file tree

Showing 5 changed files with 49 additions and 23 deletions.
diff --git a/src/components/GrampsjsEvent.js b/src/components/GrampsjsEvent.js
@@ -5,6 +5,7 @@ import '@material/mwc-icon'
 import {GrampsjsObject} from './GrampsjsObject.js'
 import './GrampsjsFormEditEventDetails.js'
 import './GrampsjsFormEditTitle.js'
+import './GrampsjsTooltip.js'
 import {fireEvent} from '../util.js'
 
 const BASE_DIR = ''
@@ -29,7 +30,22 @@ export class GrampsjsEvent extends GrampsjsObject {
 
   renderProfile() {
     return html`
-      <h2>${this._renderTitle()}</h2>
+      <h2>
+        ${this._renderTitle()}
+        ${this.edit
+          ? html`
+              <mwc-icon-button
+                id="btn-edit-type"
+                icon="edit"
+                class="edit"
+                @click="${this._handleEditType}"
+              ></mwc-icon-button>
+              <grampsjs-tooltip for="btn-edit-type"
+                >${this._('Edit event type')}</grampsjs-tooltip
+              >
+            `
+          : ''}
+      </h2>
       ${this.data.description || this.edit
         ? html` <dl>
             <div>
@@ -167,6 +183,24 @@ export class GrampsjsEvent extends GrampsjsObject {
     e.stopPropagation()
     this.dialogContent = ''
   }
+
+  _handleEditType() {
+    this.dialogContent = html`
+      <grampsjs-form-edit-type
+        dialogTitle="${this._('Edit event type')}"
+        formId="event-type"
+        typeName="event_types"
+        @object:save="${this._handleSaveType}"
+        @object:cancel="${this._handleCancelDialog}"
+        .strings=${this.strings}
+        .data=${{
+          type: this.data?.type?.string || this.data?.type || '',
+        }}
+        prop="value"
+      >
+      </grampsjs-form-edit-type>
+    `
+  }
 }
 
 window.customElements.define('grampsjs-event', GrampsjsEvent)
diff --git a/src/components/GrampsjsNote.js b/src/components/GrampsjsNote.js
@@ -6,7 +6,6 @@ import {GrampsjsObject} from './GrampsjsObject.js'
 import './GrampsjsNoteContent.js'
 import './GrampsjsEditor.js'
 import './GrampsjsFormEditType.js'
-import {fireEvent} from '../util.js'
 
 export class GrampsjsNote extends GrampsjsObject {
   static get styles() {
@@ -69,16 +68,6 @@ export class GrampsjsNote extends GrampsjsObject {
       </grampsjs-form-edit-type>
     `
   }
-
-  _handleSaveType(e) {
-    fireEvent(this, 'edit:action', {
-      action: 'updateProp',
-      data: e.detail.data,
-    })
-    e.preventDefault()
-    e.stopPropagation()
-    this.dialogContent = ''
-  }
 }
 
 window.customElements.define('grampsjs-note', GrampsjsNote)
diff --git a/src/components/GrampsjsObject.js b/src/components/GrampsjsObject.js
@@ -648,6 +648,16 @@ export class GrampsjsObject extends GrampsjsTranslateMixin(LitElement) {
     this.dialogContent = ''
   }
 
+  _handleSaveType(e) {
+    fireEvent(this, 'edit:action', {
+      action: 'updateProp',
+      data: e.detail.data,
+    })
+    e.preventDefault()
+    e.stopPropagation()
+    this.dialogContent = ''
+  }
+
   _getZoomFromBounds(bounds) {
     const xMin = bounds[0][0]
     const yMin = bounds[0][1]

diff --git a/src/components/GrampsjsPlace.js b/src/components/GrampsjsPlace.js
@@ -113,6 +113,7 @@ export class GrampsjsPlace extends GrampsjsObject {
   _handleEditType() {
     this.dialogContent = html`
       <grampsjs-form-edit-type
+        dialogTitle="${this._('Edit place type')}"
         formId="place-type"
         typeName="place_types"
         @object:save="${this._handleSaveType}"
@@ -127,16 +128,6 @@ export class GrampsjsPlace extends GrampsjsObject {
     `
   }
 
-  _handleSaveType(e) {
-    fireEvent(this, 'edit:action', {
-      action: 'updateProp',
-      data: e.detail.data,
-    })
-    e.preventDefault()
-    e.stopPropagation()
-    this.dialogContent = ''
-  }
-
   _handleSaveName(e) {
     fireEvent(this, 'edit:action', {
       action: 'updateProp',

diff --git a/src/lang/en.json b/src/lang/en.json
@@ -121,5 +121,7 @@
   "Attachments": "Attachments",
   "Event Year": "Event Year",
   "Common ancestors": "Common ancestors",
-  "Blocked": "Blocked"
+  "Blocked": "Blocked",
+  "Edit event type": "Edit event type",
+  "Edit place type": "Edit place type"
 }