close stale rta connections #200
Conversation
This rename is needed so that delete_in_connections can be added.
This is needed so that a max_in_connection_count can be added.
It was already possible to limit outgoing connections. One might want to do this on home network connections with high bandwidth but low usage caps.
Previously, the method name was printed as an exmpty string because the input string had already been moved with `std::move`.
Previous code was unable to distingush between a connection error and a communication error.
Original implementations could never have worked.
…rta-alpha3-limit-incoming-connections
mbg033
requested review from
LenyKholodov,
EDDragonWolf,
cybay,
bitkis and
AlexanderSuprunenko
Mostly RTA connections will be closed
mbg033
force-pushed
the
merge/rta-alpha3-limit-incoming-connections
branch
from
41173a7 to
1b4324e
Compare
mbg033
force-pushed
the
merge/rta-alpha3-limit-incoming-connections
branch
from
1b4324e to
efe66a5
Compare
|
This PR seems like it is trying to paint over a bug. We are repeatedly observing consistent excess connections that get established between the same two nodes are aren't used/don't handshake; this PR seems to do nothing to actually fix the source of the issue but rather just tries to deal with the symptom. |
True, RTA tunnel connections don't use handshakes (while p2p cryptonote connections do). This way RTA tunnel connections will always have this state =
This is just "extra safety", tunnel connections supposed to be closed with "idle timer" implemented in #199 |
periodically (5s) closes in/out connections with state "state_before_handshake" if connections number exceeds max allowed (in-peers and out-peers)