-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sqlite3-binding.c error 'pread64' undeclared here #68
Conversation
Hi @szkiba , It seems that some of the tests for 1.20.x failed, should I remove the update to 1.22 from this PR ? |
Yes, since it is not related to sqlite bindings.... |
885b3ac
to
c9f70af
Compare
c9f70af
to
c27116c
Compare
Thanks for confirming. I just reverted it back to Go 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
LGTM
go.mod
Outdated
@@ -1,6 +1,6 @@ | |||
module github.com/grafana/xk6-sql | |||
|
|||
go 1.21 | |||
go 1.22 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jt-shippit Could you explain why this is necessary? One of the workflow tests does not run successfully because of this version change...
Hi team,
The purpose of this PR is to resolve the following error while trying to build the Dockerfile supplied by this repo, the issue is related to the absence of certain functions (pread64, pwrite64, and off64_t) that are typically available in a glibc environment, but not in musl libc, which is used by Alpine Linux. So as a solution, I am proposing to use a distroless debian image which uses glibc and provides the necessary functions for building SQLite with the Go bindings.