Change to using sobek instead of goja #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
requested review from
olegbespalov and
joanlopez
and removed request for
a team
mstoykov
changed the title
olegbespalov
reviewed
Jun 6, 2024
go.mod
Outdated
| @@ -17,39 +17,53 @@ require ( | |||
| // we need to use the same version of the dependencies as k6. | |||
| replace github.com/spf13/afero => github.com/spf13/afero v1.1.2 | |||
There was a problem hiding this comment.
TBH, I believe we don't need this. Can we maybe clean this as part of the Sobek?
olegbespalov
approved these changes
Jun 6, 2024
|
I cleaned it up in #34 and will rebase this on it after it is merged. |
|
Ah, all tests failed 😢 |
mstoykov
changed the title
We are moving to a fork of goja under grafana org called sobek. More info in: - grafana/k6#3772 - grafana/k6#3773
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are moving to a fork of goja under grafana org called sobek.
More info in: