[fix] Fix persistence of chart scale selection #164
Conversation
- Add global time range context - Update chart hook to handle scale selection
There was a problem hiding this comment.
It works perfectly. (I ran an asset generation and pushed it)
I have only one comment: I think there should be some visual feedback that a time interval is currently selected and therefore the graphs are not updated. For example, a button in the header: "enable refresh" or similar. Otherwise, the user will not know how to enable it and why it is not updated (especially after switching tabs).
- Add time range reset button component - Add footer component - Add rewind-time icon - Update button styles
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
Screen.Recording.2024-02-09.at.11.41.22.mov |
There was a problem hiding this comment.
@2Steaks That's what I was thinking about the button, thanks.
I also like that it is responsive. Is there a reason why the button is placed at the bottom of the page in the case of a small browser window? At the top of the page, the tabs are placed in a separate row, which would also fit the "reset time range" button at the top of the page.
My other comment is that the "reset time range" button should not be displayed in the summary tab, because nothing there depends on the selected time frame. In general, if there is no chart on the page, this button should not be used. This would visually lead to the top row "jumping", because a button would disappear from the middle. Perhaps this button could be placed in front of the icons (with an appropriate design), and then it wouldn't be disturbing if it disappeared from time to time. The other option is that it will be disabled if there is no chart on the page.
There was a problem hiding this comment.
The "reset time range" button should not be displayed in the summary tab, because nothing there depends on the selected time frame. In general, if there is no chart on the page, this button should not be used. This would visually lead to the top row "jumping", because a button would disappear from the middle. Perhaps this button could be placed in front of the icons (with an appropriate design), and then it wouldn't be disturbing if it disappeared from time to time. The other option is that it will be disabled if there is no chart on the page.
# Conflicts: # dashboard/assets/packages/ui/dist/assets/index-4796c824.js # dashboard/assets/packages/ui/dist/assets/index-5a43f090.js # dashboard/assets/packages/ui/dist/assets/index-d358b692.js # dashboard/assets/packages/ui/dist/index.html
I have switched the collapsing order for mobile so that the nav items stay next to the logo, and the actions (reset, report, etc..) drop to the next row.
2Steaks
requested review from
pablochacin and
szkiba
and removed request for
a team
UI updated: example.mov |
Closes #153
What?
This PR fixes an issue with the time range selection persisting upon data refresh.
Note
This does NOT fix active chart selection: #154
Why?
The time range selection would reset with every data update.
Additional context
Screen.Recording.2024-02-05.at.10.50.33.mov
Checklist
mage lint) and all checks pass.mage test) and all tests pass.