Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparse stats graphed incorrectly? #28

Closed
cwilso03 opened this issue Jun 3, 2023 · 8 comments · Fixed by #45
Closed

Sparse stats graphed incorrectly? #28

cwilso03 opened this issue Jun 3, 2023 · 8 comments · Fixed by #45

Comments

@cwilso03
Copy link

cwilso03 commented Jun 3, 2023

Thanks for a truly great plugin for k6! In using it this last week, I believe there may be an error in how some of the stats are being plotted. If you look at the attached screen shot, you can see there are 10 "humps" of activity in this increasing load test run. But the graphs don't show the "humps" on the same time scale. For example, in the "Generated Load" chart, the virtual user count is correct over the life of the test, ending at ~9:12 PM, but the "request rate" appears to stop at ~8:44 PM. Similarly, the three "Load Time" charts seem to show the activity "humps" compressed in the time scale.

I'm not certain of the cause, but I believe, for the Load Time stats at least (as they are my own custom metrics being gathered), it may be because the stats are not recorded on a set interval; rather, the measured time is only recorded when all of a series of queries against the server all complete successfully. Since, as the load increases the frequency of errors also increases, the later "humps" have fewer data points (as fewer of the request batches complete successfully).

Does the chart assume all data points for a given metric are occurring at the same time interval?

image

@szkiba
Copy link
Collaborator

szkiba commented Jun 3, 2023

Thank you for reporting, I'll investigate.

@szkiba
Copy link
Collaborator

szkiba commented Jun 3, 2023

@cwilso03 could rerun the test, save output to compressed JSON (--out=json=results.gz) and attach it please..
Also your custom config and command line args (ie period) would be helpful.

@cwilso03
Copy link
Author

cwilso03 commented Jun 5, 2023

@szkiba - will do. It may take me a couple days before I'll be able to submit the additional info requested.

@cwilso03
Copy link
Author

@szkiba Attached are the files requested. For the dashboard command, I specified a period of 1 second (1s).

Custom dashboard config: config.tar.gz

Test results data (JSON): single-server.gz

@szkiba
Copy link
Collaborator

szkiba commented Jun 26, 2023

Sorry for the delay. I'm asking for a little more patience, I'm on vacation, and then I'll start a new job. I can probably deal with the problem in mid-August.

@cwilso03
Copy link
Author

No problem at all. Thanks again for the great plugin!

@szkiba
Copy link
Collaborator

szkiba commented Aug 18, 2023

Hi @cwilso03 , Thank you for your patience. The fix is ready, I have attached the report generated from your data (in the meantime, this feature has also been completed, which can be used to save the report to a file). Version v0.5.2 contains the fix. I would be happy if you have time to confirm.
report-28.html.gz

@cwilso03
Copy link
Author

Hi @szkiba, I can confirm the graphing looks correct now. Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants