fix: Fix data collection when not every events contains all metrics (#28

)
grafana · Aug 18, 2023 · 5ede59b · 5ede59b
1 parent 718cb44
commit 5ede59b
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 17 deletions.
diff --git a/assets/brief/index.html b/assets/brief/index.html
diff --git a/assets/packages/brief/src/metrics.js b/assets/packages/brief/src/metrics.js
@@ -19,6 +19,8 @@ class Metrics {
   pushOne (key, value) {
     if (!this.values.hasOwnProperty(key)) {
       this.values[key] = Array(this.length)
+    } else if (this.values[key].length < this.length) {
+      this.values[key][this.length-1] = undefined
     }
 
     this.values[key].push(roundTo(value, 4))

diff --git a/assets/packages/ui/src/metrics.js b/assets/packages/ui/src/metrics.js
@@ -32,6 +32,8 @@ class Metrics {
   pushOne (key, value) {
     if (!this.values.hasOwnProperty(key)) {
       this.values[key] = Array(this.length)
+    } else if (this.values[key].length < this.length) {
+      this.values[key][this.length-1] = undefined
     }
 
     this.values[key].push(roundTo(value, 4))

diff --git a/assets/ui/assets/index-aa15e9e4.js → assets/ui/assets/index-ec9aa95e.js b/assets/ui/assets/index-aa15e9e4.js → assets/ui/assets/index-ec9aa95e.js
diff --git a/assets/ui/index.html b/assets/ui/index.html
@@ -1,17 +1,20 @@
 <!DOCTYPE html>
 <html lang="en">
-  <head>
-    <meta charset="UTF-8" />
-    <link rel="icon" type="image/svg+xml" href="./xk6-dashboard.svg" />
-    <meta name="viewport" content="width=device-width, initial-scale=1.0" />
-    <script type="module" src="./boot.js"></script>
-    <script type="module" src="./init.js"></script>
-    <title>k6 dashboard</title>
-    <script type="module" crossorigin src="./assets/index-aa15e9e4.js"></script>
-    <link rel="stylesheet" href="./assets/index-fd5c5824.css">
-  </head>
-  <body>
-    <div id="root"></div>
-
-  </body>
-</html>
+
+<head>
+  <meta charset="UTF-8" />
+  <link rel="icon" type="image/svg+xml" href="./xk6-dashboard.svg" />
+  <meta name="viewport" content="width=device-width, initial-scale=1.0" />
+  <script type="module" src="./boot.js"></script>
+  <script type="module" src="./init.js"></script>
+  <title>k6 dashboard</title>
+  <script type="module" crossorigin src="./assets/index-ec9aa95e.js"></script>
+  <link rel="stylesheet" href="./assets/index-fd5c5824.css">
+</head>
+
+<body>
+  <div id="root"></div>
+
+</body>
+
+</html>