Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLO tests: make less flaky. #1943

Merged
merged 1 commit into from
Dec 6, 2024
Merged

SLO tests: make less flaky. #1943

merged 1 commit into from
Dec 6, 2024

Conversation

joeblubaugh
Copy link
Contributor

  • Runs SLO tests serially, making plan interference less likely.
  • Adds a short delay after an out-of-band SLO delete, to allow background workers to clean up the resources. This should reduce flakiness when planning after the deletion.

* Runs SLO tests serially, making plan interference less likely.
* Adds a short delay after an out-of-band SLO delete, to allow
  background workers to clean up the resources. This should reduce
  flakiness when planning after the deletion.
@joeblubaugh joeblubaugh requested review from a team as code owners December 6, 2024 11:44
Copy link

github-actions bot commented Dec 6, 2024

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link
Contributor

@elainevuong elainevuong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elainevuong elainevuong merged commit ff6465f into main Dec 6, 2024
26 checks passed
@elainevuong elainevuong deleted the joeb/slo-deflake branch December 6, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants