Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SM Checks: Select probes automatically #1909

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

julienduchesne
Copy link
Member

@julienduchesne julienduchesne commented Nov 15, 2024

Crossplane doesn't have datasources, so we have to specify probe IDs manually
This will allow us to specify a number of probes to be selected randomly

I've updated the basic examples so that they use this attribute. The advanced examples still use explicit probes

Crossplane doesn't have datasources, so we have to specify probe IDs manually
This will allow us to specify a number of probes to be selected randomly
@julienduchesne julienduchesne requested review from a team as code owners November 15, 2024 17:56
@julienduchesne julienduchesne requested review from nadiamoe and peterschretlen and removed request for a team November 15, 2024 17:56
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically.
To do so, a Grafana Labs employee must trigger the cloud acceptance tests workflow manually.

Copy link
Contributor

@peterschretlen peterschretlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections to the change itself. Looks ok to me, though a comment:

I can see a case for making this simple when people don't care where the probes are located.

Usually there are some criteria around probe selection though: US only / Europe only; private probes only. Particular if customers have a mix of public and private probes, the random selection may not see much use, or we may see requests to limit it somehow to a subset.

@julienduchesne
Copy link
Member Author

Usually there are some criteria around probe selection though: US only / Europe only; private probes only. Particular if customers have a mix of public and private probes, the random selection may not see much use, or we may see requests to limit it somehow to a subset.

The probes attribute keeps working the same as before, so users can select the probes as they wish with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants