-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SM Checks: Select probes automatically #1909
base: main
Are you sure you want to change the base?
Conversation
Crossplane doesn't have datasources, so we have to specify probe IDs manually This will allow us to specify a number of probes to be selected randomly
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Make switching attribute work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No objections to the change itself. Looks ok to me, though a comment:
I can see a case for making this simple when people don't care where the probes are located.
Usually there are some criteria around probe selection though: US only / Europe only; private probes only. Particular if customers have a mix of public and private probes, the random selection may not see much use, or we may see requests to limit it somehow to a subset.
The |
Crossplane doesn't have datasources, so we have to specify probe IDs manually
This will allow us to specify a number of probes to be selected randomly
I've updated the basic examples so that they use this attribute. The advanced examples still use explicit probes