Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add enable web overrides option to oncall schedules #1056

Merged
merged 4 commits into from
Oct 3, 2023

Conversation

matiasb
Copy link
Contributor

@matiasb matiasb commented Sep 25, 2023

This depends on grafana/amixr-api-go-client#14

Related to #1002

@github-actions
Copy link

In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build.

For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:

TESTARGS='-run=<testname>'

matiasb added a commit to grafana/oncall that referenced this pull request Sep 26, 2023
@matiasb matiasb force-pushed the oncall-schedule-enable-web-overrides branch from d6f7f1f to 04b5bab Compare September 28, 2023 17:35
@matiasb matiasb marked this pull request as ready for review September 28, 2023 17:37
@matiasb matiasb requested a review from a team as a code owner September 28, 2023 17:37
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the attribute on a test?

@matiasb
Copy link
Contributor Author

matiasb commented Sep 29, 2023

Can you add the attribute on a test?

Added tests, let me know if they make sense (besides this being my first contribution to the project, golang is not my usual programming language; happy to iterate as needed).

@matiasb matiasb force-pushed the oncall-schedule-enable-web-overrides branch from 4e8caf2 to a99cbf1 Compare October 2, 2023 17:05
Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than some parameter casing

internal/resources/oncall/resource_schedule_test.go Outdated Show resolved Hide resolved
@matiasb matiasb force-pushed the oncall-schedule-enable-web-overrides branch from a99cbf1 to 4df2d5e Compare October 3, 2023 12:44
@matiasb
Copy link
Contributor Author

matiasb commented Oct 3, 2023

LGTM other than some parameter casing

Oops, right, sorry for that, pushing update 👍

Copy link
Member

@julienduchesne julienduchesne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@julienduchesne julienduchesne merged commit 8db6565 into master Oct 3, 2023
1 check passed
@julienduchesne julienduchesne deleted the oncall-schedule-enable-web-overrides branch October 3, 2023 12:56
@Hronom
Copy link

Hronom commented Oct 10, 2023

Hello when this expected to be released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants