-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enable web overrides option to oncall schedules #1056
Conversation
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. To do so, a Grafana Labs employee must promote the Drone build. For maintainers, it's better to run only the Cloud tests you need, rather than all of them. You can do so by setting the following parameter when promoting:
|
Related updates (to be merged afterwards): - grafana/amixr-api-go-client#14 - grafana/terraform-provider-grafana#1056
d6f7f1f
to
04b5bab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the attribute on a test?
Added tests, let me know if they make sense (besides this being my first contribution to the project, golang is not my usual programming language; happy to iterate as needed). |
4e8caf2
to
a99cbf1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than some parameter casing
a99cbf1
to
4df2d5e
Compare
Oops, right, sorry for that, pushing update 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Hello when this expected to be released? |
This depends on grafana/amixr-api-go-client#14
Related to #1002