feat(ci): run required checks on merge groups #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iainlane
changed the title
iainlane
force-pushed
the
iainlane/merge-group
branch
from
96f9723
to
c5ac639
Compare
We often get several Dependabot pull requests in a short period. Our current repository settings - we require a successful build in CI, build for arm64, and require branches to be up to date - means it can be slow to manually merge them. I'd like to switch to using merge queues, then we can disable the requirement for branches to be up to date before merging, since this will be handled by the queue. Developers will then be able to review and enqueue all the PRs, and they will be tested properly against the main branch. To be able to do that we need to run the required tests for enqueued pull requests. That's what we're doing here.
iainlane
force-pushed
the
iainlane/merge-group
branch
from
c5ac639
to
c000337
Compare
dsotirakis
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We often get several Dependabot pull requests in a short period. Our current repository settings - we require a successful build in CI, build for arm64, and require branches to be up to date - means it can be slow to manually merge them.
I'd like to switch to using merge queues, then we can disable the requirement for branches to be up to date before merging, since this will be handled by the queue. Developers will then be able to review and enqueue all the PRs, and they will be tested properly against the main branch.
To be able to do that we need to run the required tests for enqueued pull requests. That's what we're doing here.