-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Plugin: Fix failing scaffolds due to marked #1319
Conversation
…e types to devDep
"marked": "^14.1.0", | ||
"marked-terminal": "^7.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This forces a refresh of the dependencies when the package is pulled via npx
so they are aligned with each other.
"@types/marked-terminal": "^6.0.1", | ||
"@types/minimist": "^1.2.2", | ||
"@types/semver": "^7.3.9", | ||
"@types/which": "^3.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't ship TS types with this package so there's no need for these to be dependencies. @types/marked-terminal
has a peer dependency on marked which was also causing limitations in the versions of marked installed via npx
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
🚀 PR was released in |
What this PR does / why we need it:
Marked terminal and marked dependencies on npx runs are resolved incorrectly and cause scaffolding to fail to succeed.
Before
After
Which issue(s) this PR fixes:
Fixes #1318
Special notes for your reviewer:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: