Remove openSearchBackendFlowEnabled toggle #545
+103
−5,461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idastambuk
requested review from
kevinwcyu and
njvrzm
and removed request for
a team
3 tasks
iwysiu
reviewed
Jan 16, 2025
| header = JSON.parse(parts[0]); | ||
| }); | ||
|
|
||
| it('should translate index pattern to current day', () => { |
There was a problem hiding this comment.
I notice we only kept the 'should not resolve the variable in the original alias field in the query', are the other tests just not applicable anymore?
There was a problem hiding this comment.
Since the others in the describe block test query building, which we do on the backend now, I don't think so
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer: