Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Storage] Update default ReplicaTemplate label selector #9915

Merged
merged 2 commits into from
Nov 15, 2024
Merged

[Ingest Storage] Update default ReplicaTemplate label selector #9915

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3b79f0e
[Ingest Storage jsonnet] Update default ReplicaTemplate label selector
flxbk Nov 15, 2024
57125b9
generate jsonnet tests
flxbk Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...ns/mimir-tests/test-ingest-storage-autoscaling-custom-stabilization-window-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2947,7 +2947,7 @@ metadata:
name: ingester-zone-a
namespace: default
spec:
labelSelector: name=unused
labelSelector: name=ingester-zone-a
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-tests/test-ingest-storage-autoscaling-multiple-triggers-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2947,7 +2947,7 @@ metadata:
name: ingester-zone-a
namespace: default
spec:
labelSelector: name=unused
labelSelector: name=ingester-zone-a
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-tests/test-ingest-storage-autoscaling-one-trigger-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2947,7 +2947,7 @@ metadata:
name: ingester-zone-a
namespace: default
spec:
labelSelector: name=unused
labelSelector: name=ingester-zone-a
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-tests/test-ingest-storage-migration-step-10-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2780,7 +2780,7 @@ metadata:
name: ingester-zone-a
namespace: default
spec:
labelSelector: name=unused
labelSelector: name=ingester-zone-a
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-tests/test-ingest-storage-migration-step-11-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2784,7 +2784,7 @@ metadata:
name: ingester-zone-a
namespace: default
spec:
labelSelector: name=unused
labelSelector: name=ingester-zone-a
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
Expand Down
2 changes: 1 addition & 1 deletion operations/mimir-tests/test-ingest-storage-migration-step-final-generated.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2947,7 +2947,7 @@ metadata:
name: ingester-zone-a
namespace: default
spec:
labelSelector: name=unused
labelSelector: name=ingester-zone-a
---
apiVersion: keda.sh/v1alpha1
kind: ScaledObject
Expand Down
5 changes: 2 additions & 3 deletions operations/mimir/ingest-storage-ingester-autoscaling.libsonnet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,8 @@
ingest_storage_ingester_autoscaling_ingester_annotations_enabled: $._config.ingest_storage_ingester_autoscaling_enabled,

// Make label selector in ReplicaTemplate configurable. This mostly doesn't matter, but from our experience if the selector
// doesn't match correct pods, HPA in GKE will display wrong usage in "kubectl describe hpa". This is harmless, but can
// easily be fixed by using name=ingester-zone-a. (We will roll out that change internally, and then upstream).
ingest_storage_replica_template_label_selector: 'name=unused',
// doesn't match correct pods, HPA in GKE will display wrong usage in "kubectl describe hpa".
ingest_storage_replica_template_label_selector: 'name=ingester-zone-a',

// Make triggers configurable so that we can add more. Each object needs to have: query, threshold, metric_type.
ingest_storage_ingester_autoscaling_triggers: [
Expand Down
Loading