change: replace cortex_discarded_samples_total label to sample-timestamp-too-old #9885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickAnge
changed the title
…too-old This change was made in order to match err-mimir-sample-timestamp-too-old event logs
NickAnge
force-pushed
the
nickange/ingester/fix-metric-label-sample-out-of-bounds
branch
from
8b52dc9
to
27b7229
Compare
NickAnge
changed the title
Signed-off-by: Nikos Angelopoulos <[email protected]>
NickAnge
force-pushed
the
nickange/ingester/fix-metric-label-sample-out-of-bounds
branch
from
a44f512
to
b3f2a61
Compare
dimitarvdimitrov
approved these changes
Nov 14, 2024
|
Thanks @dimitarvdimitrov . I updated it here https://github.com/grafana/backend-enterprise/pull/7628. I assume I need to merge it after this one. Also I see that @pr00se , has self-requested a review which is part of the ingest team if I am not mistaken |
pr00se
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change was made in order to match err-mimir-sample-timestamp-too-old event logs
What this PR does
This PR replaces
cortex_discarded_samples_totallabel fromsample-out-of-boundstosample-timestamp-too-old.Which issue(s) this PR fixes or relates to
Fixes #5970
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX].about-versioning.mdupdated with experimental features.